From 9b420b5698c4be200f03c027800e01e57835def9 Mon Sep 17 00:00:00 2001 From: Googler Date: Wed, 2 Nov 2022 14:22:07 -0700 Subject: [PATCH] Roll forward https://github.com/bazelbuild/bazel/commit/1fdc6286cb44e758add69aa4cc078f2d06d3fbdb: default --incompatible_config_setting_private_default_visibility to true This was rolled back in https://github.com/bazelbuild/bazel/commit/d4fc6db579602777916c66795b49e804e08a297f due to failing Bazel downstream tests. I fixed as many as I was aware of: see latest comments on https://github.com/bazelbuild/bazel/issues/12933. Fixes https://github.com/bazelbuild/bazel/issues/12933. PiperOrigin-RevId: 485694298 Change-Id: Ie38ce2f6cdbf952a208de37a96658770004b2bf8 --- .../google/devtools/build/lib/pkgcache/PackageOptions.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/main/java/com/google/devtools/build/lib/pkgcache/PackageOptions.java b/src/main/java/com/google/devtools/build/lib/pkgcache/PackageOptions.java index 44574dd4b2efc5..deddba03bb2d9c 100644 --- a/src/main/java/com/google/devtools/build/lib/pkgcache/PackageOptions.java +++ b/src/main/java/com/google/devtools/build/lib/pkgcache/PackageOptions.java @@ -136,7 +136,9 @@ public ParallelismConverter() throws OptionsParsingException { @Option( name = "incompatible_config_setting_private_default_visibility", - defaultValue = "false", + // TODO(b/179944632): remove this flag when all repos work with this=true + + // --incompatible_enforce_config_setting_visibility=true. + defaultValue = "true", documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS, effectTags = {OptionEffectTag.LOADING_AND_ANALYSIS}, metadataTags = {OptionMetadataTag.INCOMPATIBLE_CHANGE},