Get rid of Skyframe interaction while calculating --fdo_optimize flag value.

This is required to avoid [Skyframe restart](https://github.com/bazelbuild/bazel/blob/0dd106e83ccbc149e31ef9ffeab76ab5f1bffdc6/src/main/java/com/google/devtools/build/lib/rules/cpp/CcToolchain.java#L109-L112) in `cc_toolchain` rule.

After some research as it appears the only reason a custom `SkyFunction` was introduced for `--fdo_optimize` flag is to calculate full path in case its value was specified as a relative path to the workspace directory(interaction in [FdoHelper](https://github.com/bazelbuild/bazel/blob/0dd106e83ccbc149e31ef9ffeab76ab5f1bffdc6/src/main/java/com/google/devtools/build/lib/rules/cpp/FdoHelper.java#L84-L96) and full path [calculation](https://github.com/bazelbuild/bazel/blob/0dd106e83ccbc149e31ef9ffeab76ab5f1bffdc6/src/main/java/com/google/devtools/build/lib/rules/cpp/CcSkyframeFdoSupportFunction.java#L54)). This is a hard blocker for Starlarkification of cc_toolchain rule and also not ideal to have FDO specific `SkyFunction` baked into `Bazel`.

Therefore the decision to *not* support relative paths for `--fdo_optimize` flag can  be justified. This is a breaking change however relative paths should be easy to replace with `labels` to [`fdo_profile`](https://bazel.build/reference/be/c-cpp#fdo_profile) targets or fully qualified paths.

PiperOrigin-RevId: 526912841
Change-Id: I392cb8dee5d18398d8db643d0899f554b3542d7a

Author: buildbreaker2021

src/main/java/com/google/devtools/build/lib/bazel/rules/BazelRulesModule.java

@@ -15,23 +15,18 @@
 package com.google.devtools.build.lib.bazel.rules;
 
 import com.google.common.collect.ImmutableList;
-import com.google.devtools.build.lib.analysis.BlazeDirectories;
 import com.google.devtools.build.lib.analysis.ConfiguredRuleClassProvider;
 import com.google.devtools.build.lib.bazel.rules.cpp.BazelCppRuleClasses;
 import com.google.devtools.build.lib.bazel.rules.sh.BazelShRuleClasses;
 import com.google.devtools.build.lib.buildtool.BuildRequest;
 import com.google.devtools.build.lib.exec.ModuleActionContextRegistry;
 import com.google.devtools.build.lib.remote.options.RemoteOptions;
-import com.google.devtools.build.lib.rules.cpp.CcSkyframeFdoSupportFunction;
-import com.google.devtools.build.lib.rules.cpp.CcSkyframeFdoSupportValue;
 import com.google.devtools.build.lib.rules.cpp.CppOptions;
 import com.google.devtools.build.lib.rules.java.JavaCompileActionContext;
 import com.google.devtools.build.lib.rules.java.JavaOptions;
 import com.google.devtools.build.lib.runtime.BlazeModule;
-import com.google.devtools.build.lib.runtime.BlazeRuntime;
 import com.google.devtools.build.lib.runtime.Command;
 import com.google.devtools.build.lib.runtime.CommandEnvironment;
-import com.google.devtools.build.lib.runtime.WorkspaceBuilder;
 import com.google.devtools.build.lib.server.FailureDetails.FailureDetail;
 import com.google.devtools.build.lib.server.FailureDetails.RemoteExecution;
 import com.google.devtools.build.lib.server.FailureDetails.RemoteExecution.Code;
@@ -556,13 +551,6 @@ public void beforeCommand(CommandEnvironment env) throws AbruptExitException {
     validateRemoteOutputsMode(env);
   }
 
-  @Override
-  public void workspaceInit(
-      BlazeRuntime runtime, BlazeDirectories directories, WorkspaceBuilder builder) {
-    builder.addSkyFunction(
-        CcSkyframeFdoSupportValue.SKYFUNCTION, new CcSkyframeFdoSupportFunction(directories));
-  }
-
   @Override
   public Iterable<Class<? extends OptionsBase>> getCommandOptions(Command command) {
     return "build".equals(command.name())

src/main/java/com/google/devtools/build/lib/rules/cpp/CcSkyframeFdoSupportFunction.java

@@ -211,6 +211,12 @@ public CppConfiguration(BuildOptions options) throws InvalidConfigurationExcepti
         }
       } else {
         fdoPath = PathFragment.create(cppOptions.getFdoOptimize());
+        if (!fdoPath.isAbsolute()) {
+          throw new InvalidConfigurationException(
+              "Path of '"
+                  + fdoPath.getPathString()
+                  + "' in --fdo_optimize has to be either an absolute path or a label.");
+        }
         try {
           // We don't check for file existence, but at least the filename should be well-formed.
           FileSystemUtils.checkBaseName(fdoPath.getBaseName());

src/main/java/com/google/devtools/build/lib/rules/cpp/CcSkyframeFdoSupportValue.java

@@ -31,8 +31,6 @@
 import com.google.devtools.build.lib.util.Pair;
 import com.google.devtools.build.lib.vfs.FileSystemUtils;
 import com.google.devtools.build.lib.vfs.PathFragment;
-import com.google.devtools.build.skyframe.SkyFunction;
-import com.google.devtools.build.skyframe.SkyKey;
 import javax.annotation.Nullable;
 
 /** Helper responsible for creating {@link FdoContext} */
@@ -82,18 +80,10 @@ public static FdoContext getFdoContext(
 
       if (cppConfiguration.getFdoPath() != null) {
         PathFragment fdoZip = cppConfiguration.getFdoPath();
-        SkyKey fdoKey = CcSkyframeFdoSupportValue.key(fdoZip);
-        SkyFunction.Environment skyframeEnv = ruleContext.getAnalysisEnvironment().getSkyframeEnv();
-        CcSkyframeFdoSupportValue ccSkyframeFdoSupportValue =
-            (CcSkyframeFdoSupportValue) skyframeEnv.getValue(fdoKey);
-        if (skyframeEnv.valuesMissing()) {
-          return null;
-        }
         // fdoZip should be set if the profile is a path, fdoInputFile if it is an artifact, but
         // never both
         Preconditions.checkState(fdoInputFile == null);
-        fdoInputFile =
-            FdoInputFile.fromAbsolutePath(ccSkyframeFdoSupportValue.getFdoZipPath().asFragment());
+        fdoInputFile = FdoInputFile.fromAbsolutePath(fdoZip);
       } else if (cppConfiguration.getFdoOptimizeLabel() != null) {
         FdoProfileProvider fdoProfileProvider = attributes.getFdoOptimizeProvider();
         if (fdoProfileProvider != null) {

src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java

@@ -31,8 +31,6 @@
 import com.google.devtools.build.lib.packages.util.MockCcSupport;
 import com.google.devtools.build.lib.packages.util.MockPythonSupport;
 import com.google.devtools.build.lib.packages.util.MockToolsConfig;
-import com.google.devtools.build.lib.rules.cpp.CcSkyframeFdoSupportFunction;
-import com.google.devtools.build.lib.rules.cpp.CcSkyframeFdoSupportValue;
 import com.google.devtools.build.lib.rules.repository.LocalRepositoryFunction;
 import com.google.devtools.build.lib.rules.repository.LocalRepositoryRule;
 import com.google.devtools.build.lib.rules.repository.RepositoryDelegatorFunction;
@@ -149,9 +147,7 @@ public ImmutableMap<SkyFunctionName, SkyFunction> getSkyFunctions(BlazeDirectori
         SkyFunctions.BAZEL_MODULE_RESOLUTION,
         new BazelModuleResolutionFunction(),
         SkyFunctions.CLIENT_ENVIRONMENT_VARIABLE,
-        new ClientEnvironmentFunction(new AtomicReference<>(ImmutableMap.of())),
-        CcSkyframeFdoSupportValue.SKYFUNCTION,
-        new CcSkyframeFdoSupportFunction(directories));
+        new ClientEnvironmentFunction(new AtomicReference<>(ImmutableMap.of())));
   }
 
   // Allow subclasses to add extra repository functions.

src/main/java/com/google/devtools/build/lib/rules/cpp/FdoHelper.java

@@ -67,7 +67,7 @@ private LtoBackendAction setupAndRunToolchainActions(String... config) throws Ex
                     MockCcSupport.FSAFDO));
 
     List<String> testConfig =
-        Lists.newArrayList("--fdo_optimize=pkg/profile.afdo", "--compilation_mode=opt");
+        Lists.newArrayList("--fdo_optimize=/pkg/profile.afdo", "--compilation_mode=opt");
     Collections.addAll(testConfig, config);
     useConfiguration(Iterables.toArray(testConfig, String.class));
 
@@ -97,7 +97,6 @@ public void fsafdoEnabledWithImplicit() throws Exception {
         "          srcs = ['binfile.cc', ],",
         "          malloc = '//base:system_malloc')");
     scratch.file("pkg/binfile.cc", "int main() {}");
-    scratch.file("pkg/profile.afdo", "");
 
     LtoBackendAction backendAction = setupAndRunToolchainActions("--features=implicit_fsafdo");
 
@@ -115,7 +114,6 @@ public void fsafdoEnabledWithFeatureWithoutImplicit() throws Exception {
         "          srcs = ['binfile.cc', ],",
         "          malloc = '//base:system_malloc')");
     scratch.file("pkg/binfile.cc", "int main() {}");
-    scratch.file("pkg/profile.afdo", "");
 
     LtoBackendAction backendAction =
         setupAndRunToolchainActions("--features=-implicit_fsafdo", "--features=fsafdo");
@@ -134,7 +132,6 @@ public void fsafdoEnabledWithExplicitFeature() throws Exception {
         "          srcs = ['binfile.cc', ],",
         "          malloc = '//base:system_malloc')");
     scratch.file("pkg/binfile.cc", "int main() {}");
-    scratch.file("pkg/profile.afdo", "");
 
     LtoBackendAction backendAction = setupAndRunToolchainActions("--features=fsafdo");
 
@@ -152,7 +149,6 @@ public void fsafdoDisabledWithFeatureWithoutImplicit() throws Exception {
         "          srcs = ['binfile.cc', ],",
         "          malloc = '//base:system_malloc')");
     scratch.file("pkg/binfile.cc", "int main() {}");
-    scratch.file("pkg/profile.afdo", "");
 
     LtoBackendAction backendAction = setupAndRunToolchainActions();
 
@@ -173,7 +169,6 @@ public void fsafdoDisabledWithExplicitFeature() throws Exception {
         "          srcs = ['binfile.cc', ],",
         "          malloc = '//base:system_malloc')");
     scratch.file("pkg/binfile.cc", "int main() {}");
-    scratch.file("pkg/profile.afdo", "");
 
     LtoBackendAction backendAction =
         setupAndRunToolchainActions("--features=implicit_fsafdo", "--features=-fsafdo");

src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisMock.java

@@ -67,7 +67,7 @@ private LtoBackendAction setupAndRunToolchainActions(String... config) throws Ex
                     MockCcSupport.SPLIT_FUNCTIONS));
 
     List<String> testConfig =
-        Lists.newArrayList("--fdo_optimize=pkg/profile.zip", "--compilation_mode=opt");
+        Lists.newArrayList("--fdo_optimize=/pkg/profile.zip", "--compilation_mode=opt");
     Collections.addAll(testConfig, config);
     useConfiguration(Iterables.toArray(testConfig, String.class));