Skip to content

Commit b740189

Browse files
kotlajacopybara-github
authored andcommitted
Flip --incompatible_disallow_java_import_exports flag
RELNOTES[inc]: java_import to require that the jars attribute be non-empty (#16385) PiperOrigin-RevId: 486976650 Change-Id: If28c1ee0476d94a3359806ab04d61427a2d4da6b
1 parent 4959d34 commit b740189

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,7 @@ public ImportDepsCheckingLevelConverter() {
596596

597597
@Option(
598598
name = "incompatible_disallow_java_import_empty_jars",
599-
defaultValue = "false",
599+
defaultValue = "true",
600600
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
601601
effectTags = {OptionEffectTag.UNKNOWN},
602602
metadataTags = {OptionMetadataTag.INCOMPATIBLE_CHANGE},

src/test/shell/integration/java_integration_test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -843,7 +843,7 @@ java_binary(
843843
EOF
844844
bazel build --incompatible_disallow_java_import_empty_jars=0 //$pkg/java/hello:hello //$pkg/java/hello:hello_deploy.jar >& "$TEST_log" \
845845
|| fail "Expected success"
846-
bazel run //$pkg/java/hello:hello -- --singlejar >& "$TEST_log"
846+
bazel run --incompatible_disallow_java_import_empty_jars=0 //$pkg/java/hello:hello -- --singlejar >& "$TEST_log"
847847
expect_log "Hello World!"
848848
}
849849

0 commit comments

Comments
 (0)