Remove HostTransition.

Also remove various unused BUILD deps caught by static analysis.

PiperOrigin-RevId: 499583261
Change-Id: Ifd22bd21804233a891c4a5849ad02c897ab84ae6

Author: gregestren

src/main/java/com/google/devtools/build/lib/analysis/BUILD

@@ -64,7 +64,6 @@ java_library(
         ":config/execution_transition_factory",
         ":config/fragment",
         ":config/fragment_options",
-        ":config/host_transition",
         ":config/invalid_configuration_exception",
         ":config/per_label_options",
         ":config/run_under",
@@ -286,14 +285,12 @@ java_library(
         ":config/build_options",
         ":config/config_conditions",
         ":config/config_matching_provider",
-        ":config/core_option_converters",
         ":config/core_options",
         ":config/execution_transition_factory",
         ":config/fragment",
         ":config/fragment_class_set",
         ":config/fragment_options",
         ":config/fragment_registry",
-        ":config/host_transition",
         ":config/invalid_configuration_exception",
         ":config/per_label_options",
         ":config/run_under",
@@ -386,7 +383,6 @@ java_library(
         "//src/main/java/com/google/devtools/build/lib/actions:localhost_capacity",
         "//src/main/java/com/google/devtools/build/lib/actions:package_roots",
         "//src/main/java/com/google/devtools/build/lib/analysis/platform",
-        "//src/main/java/com/google/devtools/build/lib/analysis/starlark/annotations",
         "//src/main/java/com/google/devtools/build/lib/analysis/stringtemplate",
         "//src/main/java/com/google/devtools/build/lib/bugreport",
         "//src/main/java/com/google/devtools/build/lib/buildeventstream",
@@ -1680,10 +1676,7 @@ java_library(
     name = "config/config_aware_aspect_builder",
     srcs = ["config/ConfigAwareAspectBuilder.java"],
     deps = [
-        ":config/fragment",
-        ":config/host_transition",
         "//src/main/java/com/google/devtools/build/lib/packages",
-        "//third_party:error_prone_annotations",
     ],
 )
 
@@ -1833,23 +1826,6 @@ java_library(
     ],
 )
 
-java_library(
-    name = "config/host_transition",
-    srcs = ["config/HostTransition.java"],
-    deps = [
-        ":config/build_options",
-        ":config/core_options",
-        ":config/fragment_options",
-        ":config/transitions/patch_transition",
-        ":config/transitions/transition_factory",
-        "//src/main/java/com/google/devtools/build/lib/events",
-        "//src/main/java/com/google/devtools/build/lib/skyframe/serialization/autocodec",
-        "//src/main/java/com/google/devtools/build/lib/skyframe/serialization/autocodec:serialization-constant",
-        "//third_party:auto_value",
-        "//third_party:guava",
-    ],
-)
-
 java_library(
     name = "config/invalid_configuration_exception",
     srcs = ["config/InvalidConfigurationException.java"],
@@ -1928,7 +1904,6 @@ java_library(
     name = "config/transition_factories",
     srcs = ["config/TransitionFactories.java"],
     deps = [
-        ":config/host_transition",
         ":config/transitions/configuration_transition",
         ":config/transitions/no_transition",
         ":config/transitions/null_transition",

src/main/java/com/google/devtools/build/lib/analysis/config/HostTransition.java

@@ -21,18 +21,17 @@
 import com.google.devtools.build.lib.analysis.config.transitions.TransitionFactory;
 
 /** Useful implementations of {@link TransitionFactory}. */
-// This class is in lib.analysis.config in order to access HostTransition, which is not visible to
-// lib.analysis.config.transitions.
+// This class is in lib.analysis.config in order to access the now removed HostTransition, which
+// is not visible to lib.analysis.config.transitions.
+// TODO(b/253313672): move this to lib.analysis.config.transitions.
 public final class TransitionFactories {
   // Don't instantiate this class.
   private TransitionFactories() {}
 
   /** Returns a {@link TransitionFactory} that wraps a static transition. */
   public static <T extends TransitionFactory.Data> TransitionFactory<T> of(
       ConfigurationTransition transition) {
-    if (transition instanceof HostTransition) {
-      return HostTransition.createFactory();
-    } else if (transition instanceof NoTransition) {
+    if (transition instanceof NoTransition) {
       return NoTransition.createFactory();
     } else if (transition instanceof NullTransition) {
       return NullTransition.createFactory();

src/main/java/com/google/devtools/build/lib/analysis/config/TransitionFactories.java

@@ -37,8 +37,7 @@ public abstract class ComposingTransitionFactory<T extends TransitionFactory.Dat
    * {@code fromOptions -> transition1 -> transition2 -> toOptions }.
    *
    * <p>Note that this method checks for transition factories that cannot be composed, such as if
-   * one of the transitions is {@link NoTransition} or the host transition, and returns an
-   * efficiently composed transition.
+   * one of the transitions is {@link NoTransition}, and returns an efficiently composed transition.
    */
   public static <T extends TransitionFactory.Data> TransitionFactory<T> of(
       TransitionFactory<T> transitionFactory1, TransitionFactory<T> transitionFactory2) {
@@ -64,9 +63,8 @@ public static <T extends TransitionFactory.Data> TransitionFactory<T> of(
       // Since transitionFactory2 causes no changes, use transitionFactory1 directly.
       return transitionFactory1;
     } else if (isFinal(transitionFactory2)) {
-      // When the second transition is null or a HOST transition, there's no need to compose. But
-      // this also
-      // improves performance: host transitions are common, and ConfiguredTargetFunction has special
+      // When the second transition is null there's no need to compose. But this also improves
+      // performance: host transitions are common, and ConfiguredTargetFunction has special
       // optimized logic to handle them. If they were buried in the last segment of a
       // ComposingTransition, those optimizations wouldn't trigger.
       return transitionFactory2;
@@ -77,7 +75,7 @@ public static <T extends TransitionFactory.Data> TransitionFactory<T> of(
 
   private static <T extends TransitionFactory.Data> boolean isFinal(
       TransitionFactory<T> transitionFactory) {
-    return NullTransition.isInstance(transitionFactory) || transitionFactory.isHost();
+    return NullTransition.isInstance(transitionFactory);
   }
 
   private static <T extends TransitionFactory.Data> TransitionFactory<T> create(
@@ -96,11 +94,6 @@ public ConfigurationTransition create(T data) {
 
   abstract TransitionFactory<T> transitionFactory2();
 
-  @Override
-  public boolean isHost() {
-    return transitionFactory1().isHost() || transitionFactory2().isHost();
-  }
-
   @Override
   public boolean isTool() {
     return transitionFactory1().isTool() || transitionFactory2().isTool();

src/main/java/com/google/devtools/build/lib/analysis/config/transitions/ComposingTransitionFactory.java

@@ -91,11 +91,6 @@ public PatchTransition create(T unused) {
       return INSTANCE;
     }
 
-    @Override
-    public boolean isHost() {
-      return true;
-    }
-
     @Override
     public boolean isTool() {
       return true;

src/main/java/com/google/devtools/build/lib/analysis/config/transitions/NoConfigTransition.java

@@ -63,21 +63,12 @@ default TransitionType transitionType() {
 
   // TODO(https://github.com/bazelbuild/bazel/issues/7814): Once everything uses TransitionFactory,
   // remove these methods.
-  /** Returns {@code true} if the result of this {@link TransitionFactory} is a host transition. */
-  default boolean isHost() {
-    return false;
-  }
 
   /**
    * Returns {@code true} if the result of this {@link TransitionFactory} should be considered as
    * part of the tooling rather than a dependency of the original target.
    */
   default boolean isTool() {
-    if (isHost()) {
-      // Every host dependency is also a tool dependency.
-      return true;
-    }
-
     return false;
   }
 

src/main/java/com/google/devtools/build/lib/analysis/config/transitions/TransitionFactory.java

@@ -87,7 +87,6 @@ private static byte[] getBuildLanguageDefinition(RuleClassProvider provider) {
         attrPb.setAllowEmpty(!attr.isNonEmpty());
         attrPb.setAllowSingleFile(attr.isSingleArtifact());
         attrPb.setConfigurable(attr.isConfigurable());
-        attrPb.setCfgIsHost(attr.getTransitionFactory().isHost());
 
         // Encode default value, if simple.
         Object v = attr.getDefaultValueUnchecked();

src/main/java/com/google/devtools/build/lib/runtime/commands/info/BuildLanguageInfoItem.java

@@ -247,7 +247,6 @@ java_library(
         "//src/main/java/com/google/devtools/build/lib/analysis:config/core_options",
         "//src/main/java/com/google/devtools/build/lib/analysis:config/fragment_factory",
         "//src/main/java/com/google/devtools/build/lib/analysis:config/fragment_options",
-        "//src/main/java/com/google/devtools/build/lib/analysis:config/host_transition",
         "//src/main/java/com/google/devtools/build/lib/analysis:config/invalid_configuration_exception",
         "//src/main/java/com/google/devtools/build/lib/analysis:config/optioninfo",
         "//src/main/java/com/google/devtools/build/lib/analysis:config/starlark_defined_config_transition",

src/main/java/com/google/devtools/build/lib/skyframe/BUILD

@@ -79,7 +79,6 @@ java_library(
         "//src/main/java/com/google/devtools/build/lib/analysis:config/fragment",
         "//src/main/java/com/google/devtools/build/lib/analysis:config/fragment_options",
         "//src/main/java/com/google/devtools/build/lib/analysis:config/fragment_registry",
-        "//src/main/java/com/google/devtools/build/lib/analysis:config/host_transition",
         "//src/main/java/com/google/devtools/build/lib/analysis:config/per_label_options",
         "//src/main/java/com/google/devtools/build/lib/analysis:config/run_under",
         "//src/main/java/com/google/devtools/build/lib/analysis:config/run_under_converter",

src/test/java/com/google/devtools/build/lib/analysis/BUILD

@@ -22,7 +22,6 @@
 import com.google.common.collect.Iterables;
 import com.google.devtools.build.lib.analysis.config.BuildOptions;
 import com.google.devtools.build.lib.analysis.config.BuildOptionsView;
-import com.google.devtools.build.lib.analysis.config.HostTransition;
 import com.google.devtools.build.lib.analysis.config.TransitionFactories;
 import com.google.devtools.build.lib.cmdline.Label;
 import com.google.devtools.build.lib.events.EventHandler;
@@ -138,28 +137,6 @@ public void compose_split_split() {
                 TransitionFactories.of(new StubSplit(FLAG_2, "value2a", "value2b"))));
   }
 
-  @Test
-  public void compose_host_first() {
-    TransitionFactory<StubData> composed =
-        ComposingTransitionFactory.of(
-            HostTransition.createFactory(),
-            TransitionFactories.of(new StubPatch(FLAG_1, "value2")));
-
-    assertThat(composed).isNotNull();
-    assertThat(composed.isHost()).isTrue();
-  }
-
-  @Test
-  public void compose_host_second() {
-    TransitionFactory<StubData> composed =
-        ComposingTransitionFactory.of(
-            TransitionFactories.of(new StubPatch(FLAG_1, "value2")),
-            HostTransition.createFactory());
-
-    assertThat(composed).isNotNull();
-    assertThat(composed.isHost()).isTrue();
-  }
-
   @Test
   public void compose_noTrans_first() {
     TransitionFactory<StubData> patch = TransitionFactories.of(new StubPatch(FLAG_1, "value"));