Remove experimental option now that this can also be controlled via a crosstool feature.

PiperOrigin-RevId: 518082572
Change-Id: I3612690169216dacc32092d54f15b255c16fd3da

Author: djasper-gh

src/main/java/com/google/devtools/build/lib/bazel/rules/BazelRulesModule.java

@@ -281,6 +281,14 @@ public static class BuildGraveyardOptions extends OptionsBase {
         help = "Deprecated no-op. Use --experimental_dynamic_local_load_factor instead.")
     @Deprecated
     public boolean skipFirstBuild;
+
+    @Option(
+        name = "experimental_parse_headers_skipped_if_corresponding_srcs_found",
+        defaultValue = "false",
+        documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
+        effectTags = {OptionEffectTag.NO_OP},
+        help = "No-op.")
+    public boolean parseHeadersSkippedIfCorrespondingSrcsFound;
   }
 
   /** This is where deprecated Bazel-specific options only used by the build command go to die. */

src/main/java/com/google/devtools/build/lib/rules/cpp/CcCompilationHelper.java

@@ -1438,8 +1438,7 @@ private CcCompilationOutputs createCcCompileActions() throws RuleErrorException
         // These are already handled above.
         continue;
       }
-      if (cppConfiguration.getParseHeadersSkippedIfCorrespondingSrcsFound()
-          && featureConfiguration.isEnabled(CppRuleClasses.VALIDATES_LAYERING_CHECK_IN_TEXTUAL_HDRS)
+      if (featureConfiguration.isEnabled(CppRuleClasses.VALIDATES_LAYERING_CHECK_IN_TEXTUAL_HDRS)
           && compiledBasenames.contains(
               Files.getNameWithoutExtension(artifact.getExecPathString()))) {
         continue;

src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java

@@ -497,10 +497,6 @@ public boolean getInmemoryDotdFiles() {
     return cppOptions.inmemoryDotdFiles;
   }
 
-  public boolean getParseHeadersSkippedIfCorrespondingSrcsFound() {
-    return cppOptions.parseHeadersSkippedIfCorrespondingSrcsFound;
-  }
-
   public boolean getUseInterfaceSharedLibraries() {
     return cppOptions.useInterfaceSharedObjects;
   }

src/main/java/com/google/devtools/build/lib/rules/cpp/CppOptions.java

@@ -749,16 +749,6 @@ public Label getPropellerOptimizeLabel() {
               + "build nodes instead of being written to disk.")
   public boolean inmemoryDotdFiles;
 
-  @Option(
-      name = "experimental_parse_headers_skipped_if_corresponding_srcs_found",
-      defaultValue = "false",
-      documentationCategory = OptionDocumentationCategory.BUILD_TIME_OPTIMIZATION,
-      effectTags = {OptionEffectTag.LOADING_AND_ANALYSIS, OptionEffectTag.AFFECTS_OUTPUTS},
-      help =
-          "If enabled, the parse_headers feature does not create a separate header compile action "
-              + "if a source with the same basename is found in the same target.")
-  public boolean parseHeadersSkippedIfCorrespondingSrcsFound;
-
   @Option(
       name = "experimental_omitfp",
       defaultValue = "false",
@@ -1249,7 +1239,6 @@ public FragmentOptions getExec() {
     exec.disableNoCopts = disableNoCopts;
     exec.loadCcRulesFromBzl = loadCcRulesFromBzl;
     exec.validateTopLevelHeaderInclusions = validateTopLevelHeaderInclusions;
-    exec.parseHeadersSkippedIfCorrespondingSrcsFound = parseHeadersSkippedIfCorrespondingSrcsFound;
     exec.strictSystemIncludes = strictSystemIncludes;
     exec.useArgsParamsFile = useArgsParamsFile;
     exec.ignoreParamFile = ignoreParamFile;