Skip to content

Commit d72760b

Browse files
gregestrencopybara-github
authored andcommitted
Remove long outdated --experimental_build_setting_api.
This has been true for years and has no actual semantic impact. This is leftover from the flag-gated introduction of Bazel's Starlark flag API. PiperOrigin-RevId: 564746589 Change-Id: I4aeea41a997f821f7985ec4ef216aaea168eca61
1 parent d84d852 commit d72760b

File tree

2 files changed

+4
-14
lines changed

2 files changed

+4
-14
lines changed

src/main/java/com/google/devtools/build/lib/packages/semantics/BuildLanguageOptions.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -94,16 +94,6 @@ public final class BuildLanguageOptions extends OptionsBase {
9494
help = "No-op.")
9595
public boolean incompatibleDisallowSymlinkFileToDir;
9696

97-
@Option(
98-
name = "experimental_build_setting_api",
99-
defaultValue = "true",
100-
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
101-
effectTags = OptionEffectTag.BUILD_FILE_SEMANTICS,
102-
help =
103-
"If set to true, allows access to value of build setting rules via "
104-
+ "ctx.build_setting_value.")
105-
public boolean experimentalBuildSettingApi;
106-
10797
// TODO(#11437): Delete the special empty string value so that it's on unconditionally.
10898
@Option(
10999
name = "experimental_builtins_bzl_path",

src/main/java/com/google/devtools/build/lib/starlarkbuildapi/StarlarkRuleContextApi.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -204,10 +204,10 @@ public interface StarlarkRuleContextApi<ConstraintValueT extends ConstraintValue
204204
name = "build_setting_value",
205205
structField = true,
206206
doc =
207-
"<b>Experimental. This field is experimental and subject to change at any time. Do not "
208-
+ "depend on it.</b> <p>The value of the build setting that is represented "
209-
+ "by the current target. It is an error to access this field for rules that do not "
210-
+ "set the <code>build_setting</code> attribute in their rule definition.")
207+
"Value of the build setting represented by the current target. If this isn't the context"
208+
+ " for an instance of a rule that sets the <a href=\""
209+
+ "https://bazel.build/extending/config#rule-parameter\"><code>build_setting</code>"
210+
+ "</a> attribute, reading this is an error.")
211211
Object getBuildSettingValue() throws EvalException;
212212

213213
@StarlarkMethod(

0 commit comments

Comments
 (0)