Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible_remove_enabled_toolchain_types: Remove the enabled_toolchain_types flag and associated data #10262

Open
katre opened this issue Nov 18, 2019 · 0 comments

Comments

@katre
Copy link
Member

@katre katre commented Nov 18, 2019

Flag: --incompatible_remove_enabled_toolchain_types
Introduced in: 2.0
Will be flipped: 3.0

Description
The --enabled_toolchain_types flag was originally envisioned as a way to enable and disable specific rules using toolchains. However, this was before the incompatible change policy existed, and has turned out to not be sufficiently flexible.

No one appears to be currently using this functionality, so it should be removed. The flag and the Starlark configuration fragment accessor will be removed.

Migration
Stop using platform.enabled_toolchain_types, and instead add specific incompatible change flags for each toolchain type.

@katre katre self-assigned this Nov 18, 2019
katre added a commit to katre/bazel that referenced this issue Nov 18, 2019
This removes the "enabled_toolchain_types" field on the platform
configuration fragment in Starlark.

Part of bazelbuild#10262.
bazel-io pushed a commit that referenced this issue Nov 19, 2019
This removes the "enabled_toolchain_types" field on the platform
configuration fragment in Starlark.

Part of #10262.

Closes #10263.

RELNOTES[INC]: Adds --incompatible_remove_enabled_toolchain_types.

PiperOrigin-RevId: 281324862
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.