Do not eval WORKSPACE in LocalRepositoryLookupFunction when --noenable_workspace
#22774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-ExternalDeps
meteorcloudy
approved these changes
Jun 18, 2024
|
What was LocalRepositoryLookupFunction used for? I'm not aware its existence before.. |
meteorcloudy
added
awaiting-PR-merge
it tries to check if a given path is used as a local_repository (see also #22208 (comment)) |
github-actions
bot
removed
the
awaiting-PR-merge
|
@bazel-io fork 7.2.1 |
|
@bazel-io fork 7.3.0 |
This was referenced Jun 20, 2024
Closed
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jun 20, 2024
…le_workspace` This still leaves the question of "what do we do instead?". See issues bazelbuild#22208 and bazelbuild#21515. Fixes bazelbuild#22754. Closes bazelbuild#22774. PiperOrigin-RevId: 645148811 Change-Id: Ib9d07d2ecbc3a79e3341de6739de1c3349124d6b
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Jun 21, 2024
…le_workspace` This still leaves the question of "what do we do instead?". See issues bazelbuild#22208 and bazelbuild#21515. Fixes bazelbuild#22754. Closes bazelbuild#22774. PiperOrigin-RevId: 645148811 Change-Id: Ib9d07d2ecbc3a79e3341de6739de1c3349124d6b
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jun 27, 2024
…le_workspace` This still leaves the question of "what do we do instead?". See issues bazelbuild#22208 and bazelbuild#21515. Fixes bazelbuild#22754. Closes bazelbuild#22774. PiperOrigin-RevId: 645148811 Change-Id: Ib9d07d2ecbc3a79e3341de6739de1c3349124d6b
fmeum
pushed a commit
to fmeum/bazel
that referenced
this pull request
Jul 18, 2024
…--noenable_workspace` (bazelbuild#22837) This still leaves the question of "what do we do instead?". See issues bazelbuild#22208 and bazelbuild#21515. Fixes bazelbuild#22754. Closes bazelbuild#22774. PiperOrigin-RevId: 645148811 Change-Id: Ib9d07d2ecbc3a79e3341de6739de1c3349124d6b Commit bazelbuild@1246ff4 Co-authored-by: Xdng Yng <wyverald@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still leaves the question of "what do we do instead?". See issues #22208 and #21515.
Fixes #22754.