New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows, Skylark: cannot render Cyrillic (maybe?) #2443

Open
laszlocsomor opened this Issue Jan 27, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@laszlocsomor
Copy link
Contributor

laszlocsomor commented Jan 27, 2017

This issue is split off #2436 (comment) : apparently in log2.txt the question marks were rendered as such by MSYS. As can be seen on a screenshot earlier, the user has Windows installed in Russian. The question marks may be incorrectly rendered Cyrillic.

@laurentlb

This comment has been minimized.

Copy link
Contributor

laurentlb commented Mar 7, 2017

Skylark doesn't transform characters, so it shouldn't be an issue.
Maybe the input file and the terminal disagree on the encoding?

@laszlocsomor

This comment has been minimized.

Copy link
Contributor

laszlocsomor commented Apr 13, 2017

Assigning to Dmitry who actually speaks Russian :) (so he could evaluate a fix)

@laszlocsomor

This comment has been minimized.

Copy link
Contributor

laszlocsomor commented Dec 14, 2017

Acknowledging that this is a problem, I'm still keeping the priority as P3. Reason being that the rest of Bazel doesn't work well with non-ASCII paths anyway (labels for example don't support non-ASCII paths), and the Windows team doesn't have capacity to fix the rest of Bazel. I'm sad to say that I don't realistically see fixing this any time in the next few months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment