Join GitHub today
Bazel client, Windows: get rid of AsWindowsPath for MSVC code path #2507
Avoid using our UNIX to Windows path conversion methods (e.g.
If a binary is compiled with MSVC and thus not linked against msys-2.0.dll, then MSYS converts UNIX path arguments to Windows paths. So if Bazel is built with MSVC, we don't need the conversion methods.
We cannot completely get rid of these methods though because we use UNIX paths in places like the CROSSTOOL file. But we should get rid of calls when processing paths coming from command line arguments.
I was wrong in my earlier comment:
I think we can remove the Unix path conversion logic from the Bazel client, and probably also from the JNI library. We cannot fully remove it from the Java code though, as @tomlu also discovered.