Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update C++ gRPC from 0.13.0 #2804

Closed
lberki opened this Issue Apr 11, 2017 · 2 comments

Comments

Projects
None yet
4 participants
@lberki
Copy link
Contributor

lberki commented Apr 11, 2017

0.13.0 is truly ancient and unsupported, so it should be updated to something more recent. It'd also probably help us get rid of the Windows patch. Furthermore, it might also help with the issue whereupon a gRPC thread is still alive when we fork the server and prevents the fork from succeeding.

This probably also requires an update to protobuf.

The Java gRPC library should also be given a closer look.

@buchgr buchgr self-assigned this Apr 11, 2017

@damienmg damienmg added this to the 0.6 milestone Apr 21, 2017

@buchgr

This comment has been minimized.

Copy link
Contributor

buchgr commented May 31, 2017

gRPC Java has been updated to 1.3.0. We considered this more important, as with BEP and Remote Execution gRPC Java talks over real networks while gRPC C++ only talks over loopback.

@buchgr

This comment has been minimized.

Copy link
Contributor

buchgr commented Feb 5, 2019

@tetromino feel free to take this bug!

tetromino added a commit to tetromino/bazel that referenced this issue Feb 6, 2019

Update bundled gRPC to 1.18.0 and nanopb to 0.3.6
And take the opportunity to align third_party/grpc/BUILD closer with
gRPC upstream's BUILD file to make importing easier next time.

Fixes bazelbuild#2804.

tetromino added a commit to tetromino/bazel that referenced this issue Feb 6, 2019

Update bundled gRPC to 1.18.0 and nanopb to 0.3.6
And take the opportunity to align third_party/grpc/BUILD closer with
gRPC upstream's BUILD file (by adopting the same intermediate targets)
to make importing easier next time.

The MSYS2 patch is no longer needed judging by discussion in
https://groups.google.com/forum/#!msg/grpc-io/gd6sIuo6rjQ/eyEFarhABgAJ

Fixes bazelbuild#2804.

tetromino added a commit to tetromino/bazel that referenced this issue Feb 7, 2019

Update bundled gRPC to 1.18.0 and nanopb to 0.3.6
And take the opportunity to align third_party/grpc/BUILD closer with
gRPC upstream's BUILD file (by adopting the same intermediate targets)
to make importing easier next time.

The MSYS2 patch is no longer needed judging by discussion in
https://groups.google.com/forum/#!msg/grpc-io/gd6sIuo6rjQ/eyEFarhABgAJ

Fixes bazelbuild#2804.

@bazel-io bazel-io closed this in 458ab03 Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.