New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new_local_repository: validate `build_file` attribute (esp. on Windows) #3192

Open
abergmeier-dsfishlabs opened this Issue Jun 14, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@abergmeier-dsfishlabs
Copy link
Contributor

abergmeier-dsfishlabs commented Jun 14, 2017

Description of the problem / feature request / question:

Trying to build //:main in abergmeier-dsfishlabs@51d024e - third_party\python\test_win makes the Skylark parser throw an exception from sun.nio.fs.WindowsPathParser.normalize.

Environment info

  • Operating System: Windows 10
  • Bazel version (output of bazel info release): 0.5.1
@meteorcloudy

This comment has been minimized.

Copy link
Member

meteorcloudy commented Jun 16, 2017

Here: abergmeier-dsfishlabs@51d024e#diff-12d915cac6de6a779d777547b149656eR5

You should use build_file_content instead of build_file, otherwise bazel would consider it as a file path.

@abergmeier-dsfishlabs

This comment has been minimized.

Copy link
Contributor

abergmeier-dsfishlabs commented Jun 16, 2017

Oh, I know. Still it should IMO not throw an exception ;)

@meteorcloudy

This comment has been minimized.

Copy link
Member

meteorcloudy commented Jun 16, 2017

Yeah, a more clear error message would be better. Anyway, closing this now.

@abergmeier-dsfishlabs

This comment has been minimized.

Copy link
Contributor

abergmeier-dsfishlabs commented Jun 16, 2017

Anyway, closing this now.

Why? Shouldn't that at least get a P4 or something?

@meteorcloudy

This comment has been minimized.

Copy link
Member

meteorcloudy commented Jun 16, 2017

Fine, making it a P4 now. ;)

@meteorcloudy meteorcloudy reopened this Jun 16, 2017

@laszlocsomor laszlocsomor changed the title Skylark parser throws Exception new_local_repository: validate `build_file` attribute (esp. on Windows) Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment