New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows, Android, CI: set up CI job to build Android Hello World on Windows #3663

Open
laszlocsomor opened this Issue Sep 1, 2017 · 8 comments

Comments

Projects
None yet
3 participants
@laszlocsomor
Copy link
Contributor

laszlocsomor commented Sep 1, 2017

Set up a CI job on ci.bazel.build that builds //examples/android/java/bazel:hello_world on Windows, in order to avoid #3659 happening again.

@laszlocsomor

This comment has been minimized.

Copy link
Contributor

laszlocsomor commented Sep 11, 2017

@aj-michael : Do you have any updates on this?

@aj-michael

This comment has been minimized.

Copy link
Contributor

aj-michael commented Sep 11, 2017

I attempted to write a python test that would build it, however I am blocked by #3674. There is a workaround proposed in that issue (use glob/** instead of glob on directories), however, to use that workaround would require waiting one Bazel release after the workaround is submitted, since the workaround is for the Bazel binary that runs the test (as opposed to the binary built from head that is being tested).

I am open to other ideas. java_test does not have the issue is #3674, however we don't have an open source java framework for integration tests afaik.

@laszlocsomor

This comment has been minimized.

Copy link
Contributor

laszlocsomor commented Sep 11, 2017

Thanks!

If the only reason to use Java would be to ship this faster, and otherwise Python would allow simpler (and faster?) tests, then I suggest waiting for the release with the workaround.

Reading that bug (#3674) I get the impression that the workaround is actually the right way to glob a directory. I don't even know what glob(["some_directory"]) should do as opposed to glob(["some_directory/**"]).

@aj-michael

This comment has been minimized.

Copy link
Contributor

aj-michael commented Sep 11, 2017

The title of the bug is misleading, its not an issue with globs. The issue is that Bazel allows filegroups to contain directories (as opposed to globbing all the files within them), and py_test on Windows fails if such a filegroup is a data dependency.

bazel-io pushed a commit that referenced this issue Sep 27, 2017

Limit //external:android_sdk_for_testing to only the minimum files ne…
…eded.

Note that the support libraries are excluded on Windows, because Windows
runfiles are zipped and the support libraries are very big.

First step towards #3663

RELNOTES: None
PiperOrigin-RevId: 170057391
@laszlocsomor

This comment has been minimized.

Copy link
Contributor

laszlocsomor commented Dec 13, 2017

@aj-michael , do you have any updates on this bug?

@aj-michael

This comment has been minimized.

Copy link
Contributor

aj-michael commented Dec 13, 2017

Thanks for reminding me of this. This was blocked on #3674 (which is still unresolved), but now that 95ce534 is in a release I think I have a workaround. I'll try and get back to this this week.

@laszlocsomor

This comment has been minimized.

Copy link
Contributor

laszlocsomor commented Dec 13, 2017

Sounds great, thank you!

@bazel-io bazel-io closed this in e6a2f60 Jul 16, 2018

@jin jin reopened this Jul 16, 2018

werkt added a commit to werkt/bazel that referenced this issue Aug 2, 2018

Add //examples/... to postsubmit CI pipeline
While fixing bazelbuild#3663, I figured that it'll be great to build_test all of the targets in //examples/..., on top of the Android ones.

Tested manually on Ubuntu, macOS and Windows machines.

Fixes bazelbuild#3663

Closes bazelbuild#5108.

PiperOrigin-RevId: 204785212

werkt added a commit to werkt/bazel that referenced this issue Aug 2, 2018

Automated rollback of commit 44c53dc.
*** Reason for rollback ***

Failing on Windows: https://buildkite.com/bazel/bazel-bazel/builds/3409#825fcb71-bf05-4e59-98a3-1272957d6588

*** Original change description ***

Add //examples/... to postsubmit CI pipeline

While fixing bazelbuild#3663, I figured that it'll be great to build_test all of the targets in //examples/..., on top of the Android ones.

Tested manually on Ubuntu, macOS and Windows machines.

Fixes bazelbuild#3663

Closes bazelbuild#5108.

PiperOrigin-RevId: 204800755

@jin jin added P2 and removed P1 labels Nov 30, 2018

@jin

This comment has been minimized.

Copy link
Member

jin commented Nov 30, 2018

Downgrading to P2 as we have some coverage building Android apps on Windows in other pipelines, like Android Testing.

@jin jin removed their assignment Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment