New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NDK 17 #4742

Closed
jin opened this Issue Mar 1, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@jin
Copy link
Member

jin commented Mar 1, 2018

r17 is expected to land in May 2018.

Betas 1 and 2 will be released this month (March) and next month (April) respectively.

https://android.googlesource.com/platform/ndk/+/ndk-release-r17/CHANGELOG.md

Relevant changes:

  • libc++/@androidndk//:toolchain-libcpp will become the default STL. The other STLs will be removed in r18, or moved to another project.
  • GCC will no longer be supported.
  • Removed support for building against armeabi, mips, and mips64.
  • Removed support for API levels 14 and 15. New minimum is 16.
  • clang is updated to v6.0.2, build 4691093

@jin jin self-assigned this Mar 1, 2018

@jin jin added the P2 label Mar 2, 2018

bazel-io pushed a commit that referenced this issue Mar 15, 2018

Conditionally set the default crosstool based on the major revision b…
…y binding //external:android/crosstool to an alias in the NDK BUILD file.

This does not change existing behavior until r17 support is released.

#4742

RELNOTES: None.
PiperOrigin-RevId: 189195669
@steeve

This comment has been minimized.

Copy link

steeve commented May 22, 2018

NDK17 is was released. I haven't tested with bazel 0.14rc, but I don't see this being in the changelog.

@jin jin added P1 and removed P2 labels May 22, 2018

@jin

This comment has been minimized.

Copy link
Member

jin commented May 22, 2018

I haven't had free cycles to work on this yet. Bumping to P1 for re-prioritization.

@steeve

This comment has been minimized.

Copy link

steeve commented May 23, 2018

That's great thank you!

@jin jin referenced this issue Jun 11, 2018

Closed

Android NDK r17 support #5371

2 of 3 tasks complete
@jin

This comment has been minimized.

Copy link
Member

jin commented Jun 11, 2018

@steeve WIP: #5371

excitoon added a commit to KasperskyLab/bazel that referenced this issue Jun 20, 2018

Conditionally set the default crosstool based on the major revision b…
…y binding //external:android/crosstool to an alias in the NDK BUILD file.

This does not change existing behavior until r17 support is released.

bazelbuild#4742

RELNOTES: None.
PiperOrigin-RevId: 189195669

@bazel-io bazel-io closed this in 61a6bea Jul 18, 2018

werkt added a commit to werkt/bazel that referenced this issue Aug 2, 2018

Android NDK r17 support
[Full NDK changelog](https://github.com/android-ndk/ndk/wiki/Changelog-r17)

Changes related to Bazel's NDK toolchain/CROSSTOOL generation:

- Removed support for targeting mips, mips64, armeabi.
- Bumped bundled clang version to 6.0.2.
- The default STL is now libc++. If Bazel detects that r17 is being used, it
  aliases `@androidndk//:default_toolchain` to `@androidndk//:toolchain-libcpp`,
  instead of `@androidndk//:toolchain-gnu-libstdcpp`.
- Removed tests that build against armeabi, mips, mips64.
- Stop passing `-fno-integrated-as` into the compiler by default.

TODO:

- [x] Java tests
- [x] ~Support for wrap.sh to use with ASANs~ Implementing in follow up PR.
- [ ] Fix or disable remote caching with android_ndk_integration_test bazelbuild#4663

Fixes bazelbuild#4742

RELNOTES: Added support for Android NDK r17. The default STL is now `libc++`, and support for targeting `mips`, `mips64` and `ARMv5` (`armeabi`) has been removed.

Closes bazelbuild#5371.

Change-Id: Id1ded004c3a80ea62f307746dc3ad6f633f2df2e
PiperOrigin-RevId: 205013758
@Nimitz14

This comment has been minimized.

Copy link

Nimitz14 commented Nov 12, 2018

When calling ./configure in tensorflow I get

WARNING: The API level of the NDK in ../Android/Sdk/ndk-bundle is 17, which is not supported by Bazel (officially supported versions: [10, 11, 12, 13, 14, 15, 16]). Please use another version.

Can someone please confirm I can ignore this warning?

@jin

This comment has been minimized.

Copy link
Member

jin commented Nov 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment