Support NDK 17 #4742
Assignees
Labels
Comments
bazel-io
pushed a commit
that referenced
this issue
Mar 15, 2018
…y binding //external:android/crosstool to an alias in the NDK BUILD file. This does not change existing behavior until r17 support is released. #4742 RELNOTES: None. PiperOrigin-RevId: 189195669
|
NDK17 is was released. I haven't tested with bazel 0.14rc, but I don't see this being in the changelog. |
jin
added
P1
|
I haven't had free cycles to work on this yet. Bumping to P1 for re-prioritization. |
|
That's great thank you! |
werkt
pushed a commit
to werkt/bazel
that referenced
this issue
Aug 2, 2018
[Full NDK changelog](https://github.com/android-ndk/ndk/wiki/Changelog-r17) Changes related to Bazel's NDK toolchain/CROSSTOOL generation: - Removed support for targeting mips, mips64, armeabi. - Bumped bundled clang version to 6.0.2. - The default STL is now libc++. If Bazel detects that r17 is being used, it aliases `@androidndk//:default_toolchain` to `@androidndk//:toolchain-libcpp`, instead of `@androidndk//:toolchain-gnu-libstdcpp`. - Removed tests that build against armeabi, mips, mips64. - Stop passing `-fno-integrated-as` into the compiler by default. TODO: - [x] Java tests - [x] ~Support for wrap.sh to use with ASANs~ Implementing in follow up PR. - [ ] Fix or disable remote caching with android_ndk_integration_test bazelbuild#4663 Fixes bazelbuild#4742 RELNOTES: Added support for Android NDK r17. The default STL is now `libc++`, and support for targeting `mips`, `mips64` and `ARMv5` (`armeabi`) has been removed. Closes bazelbuild#5371. Change-Id: Id1ded004c3a80ea62f307746dc3ad6f633f2df2e PiperOrigin-RevId: 205013758
|
When calling Can someone please confirm I can ignore this warning? |
|
Yes, you can ignore it. Bazel supports up to r18 now.
…On Mon, Nov 12, 2018 at 10:34 AM Rudolf A. Braun ***@***.***> wrote:
When calling ./configure in tensorflow I get
WARNING: The API level of the NDK in /home/seni/Android/Sdk/ndk-bundle is 17, which is not supported by Bazel (officially supported versions: [10, 11, 12, 13, 14, 15, 16]). Please use another version.
Can someone please confirm I can ignore this warning?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#4742 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVPDsbXGuSn1pdoajyGCq0wQM_Pt-1aks5uuZUHgaJpZM4SYfDw>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
r17 is expected to land in May 2018.
Betas 1 and 2 will be released this month (March) and next month (April) respectively.
https://android.googlesource.com/platform/ndk/+/ndk-release-r17/CHANGELOG.md
Relevant changes:
libc++/@androidndk//:toolchain-libcppwill become the default STL. The other STLs will be removed in r18, or moved to another project.armeabi,mips, andmips64.Removed support for API levels 14 and 15. New minimum is 16.The text was updated successfully, but these errors were encountered: