Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible_disable_objc_provider_resources #5710

Closed
c-parsons opened this issue Jul 30, 2018 · 4 comments

Comments

@c-parsons
Copy link
Contributor

commented Jul 30, 2018

ObjcProvider resource fields are deprecated and will be removed. We don't expect any OSS clients from using these fields since most of their uses came from rules_apple, and have been migrated for some time now.

If you are using the following ObjcProvider fields directly, please reply on this bug for instructions on how to migrate to an acceptable approach:

  • ASSET_CATALOG
  • BUNDLE_FILE
  • ROOT_MERGE_ZIP
  • STORYBOARD
  • STRINGS
  • XCASSETS_DIR
  • XCDATAMODEL
  • XIB

Expected timeline:

released with Bazel August 2018, off by default
enabled by default with Bazel 0.25 (April 2019)

[Updated by kaipi]

@rupertks rupertks added P2 and removed untriaged labels Nov 21, 2018

bazel-io pushed a commit that referenced this issue Feb 1, 2019

Enable --incompatible_disable_objc_provider_resources by default.
#5710

RELNOTES: --incompatible_disable_objc_provider_resources is now enabled by default. This disables ObjcProvider's fields related to resource processing.
PiperOrigin-RevId: 231900540

bazel-io pushed a commit that referenced this issue Feb 4, 2019

Automated rollback of commit c1be54b.
*** Reason for rollback ***

Failures in nightly: b/123841211

*** Original change description ***

Enable --incompatible_disable_objc_provider_resources by default.

#5710

RELNOTES: --incompatible_disable_objc_provider_resources is now enabled by default. This disables ObjcProvider's fields related to resource processing.
PiperOrigin-RevId: 232305883
@philwo

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

@c-parsons Apparently this flag was flipped recently, but rolled back again. Do you want to turn this into an official incompatible flag bug and use the migration process for it, so that we can get it into the next release?

@c-parsons

This comment has been minimized.

Copy link
Contributor Author

commented Feb 6, 2019

I believe @sergiocampama intends on owning this :)
(Sergio feel free to correct me if I'm wrong)

@sergiocampama

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

@philwo should I just convert this issue into an incompatible flag issue? can I assign migration as 0.24, and flipping in 0.25, given that the flag is already rolled out?

@dslomov

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

@sergiocampama sergiocampama changed the title Tracking bug for killing off resource-related fields of Objc Provider incompatible_disable_objc_provider_resources Mar 6, 2019

bazel-io pushed a commit that referenced this issue May 1, 2019

Flip the --incompatible_disable_objc_provider_resources flag to true …
…by default.

See #5710 for more info.

RELNOTES: --incompatible_disable_objc_provider_resources is now enabled by default.
PiperOrigin-RevId: 246142200

@laurentlb laurentlb closed this May 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.