Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible_no_support_tools_in_action_inputs: Enforce action tools are passed using 'tools' and not 'inputs'. #5826

Closed
c-parsons opened this issue Aug 8, 2018 · 4 comments

Comments

@c-parsons
Copy link
Contributor

commented Aug 8, 2018

This is a tracking issue for offering a migration solution for
--incompatible_no_support_tools_in_action_inputs

This flag would change e.g. ctx.actions.run() and ctx.actions.run_shell() to enforce action tools are passed using 'tools' and not 'inputs'. (An error is thrown if any tools appear in 'inputs'

@c-parsons c-parsons self-assigned this Aug 8, 2018

@laurentlb laurentlb changed the title Enforce action tools are passed using 'tools' and not 'inputs'. incompatible_no_support_tools_in_action_inputs: Enforce action tools are passed using 'tools' and not 'inputs'. Jan 9, 2019

@dslomov

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2019

@c-parsons when do you intend to flip the flag?

@laurentlb

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

Still blocked by Tensorflow, rules_k8s, Cloud Robotics Core, Bazel Watcher, Baze;l Remote Cache. All of them have been pinged.

@laurentlb

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/67

@c-parsons Can you see how to fix Bazel? (looks like we need to update something in third-party)

I'll ping the other projects.

@meteorcloudy

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

Looks like the latest protobuf release is still broken with this flag

pcloudy@pcloudy:~/workspace/tensorflow
$ bazelisk  build --config=opt //tensorflow/tools/pip_package:build_pip_package --incompatible_no_support_tools_in_action_inputs
INFO: Build option --incompatible_windows_escape_jvm_flags has changed, discarding analysis cache.
ERROR: /usr/local/google/home/pcloudy/workspace/tensorflow/tensorflow/contrib/rpc/python/kernel_tests/BUILD:13:1: in proto_gen rule //tensorflow/contrib/rpc/python/kernel_tests:test_example_proto_py_genproto: 
Traceback (most recent call last):
        File "/usr/local/google/home/pcloudy/workspace/tensorflow/tensorflow/contrib/rpc/python/kernel_tests/BUILD", line 13
                proto_gen(name = 'test_example_proto_py_genproto')
        File "/usr/local/google/home/pcloudy/.cache/bazel/_bazel_pcloudy/d2f15366e3b15100d3593f2d595721a3/external/protobuf_archive/protobuf.bzl", line 137, in _proto_gen_impl
                ctx.actions.run(inputs = inputs, outputs = outs, arg...]), <3 more arguments>)
Found tool(s) 'bazel-out/host/bin/external/grpc/grpc_python_plugin' in inputs. A tool is an input with executable=True set. All tools should be passed using the 'tools' argument instead of 'inputs' in order to make their runfiles available to the action. This safety check will not be performed once the action is modified to take a 'tools' argument. To temporarily disable this check, set --incompatible_no_support_tools_in_action_inputs=false.
ERROR: Analysis of target '//tensorflow/tools/pip_package:build_pip_package' failed; build aborted: Analysis of target '//tensorflow/contrib/rpc/python/kernel_tests:test_example_proto_py_genproto' failed; build aborted
INFO: Elapsed time: 1.691s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (291 packages loaded, 6072 targets configured)

Is there a fix for that?

@bazel-io bazel-io closed this in 0e6dcee May 31, 2019

meteorcloudy added a commit to meteorcloudy/protobuf that referenced this issue Jun 4, 2019

Pass ctx.executable.protoc in tools
This is another fix for `--incompatible_no_support_tools_in_action_inputs`
bazelbuild/bazel#5826

TensorFlow is broken due to this:
https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1014#f7a58799-a361-4087-82fb-f0c54ed2be49
```
Traceback (most recent call last):
	File "/var/lib/buildkite-agent/builds/bk-docker-g96n/bazel-downstream-projects/tensorflow/tensorflow/contrib/rpc/python/kernel_tests/BUILD", line 14
		proto_gen(name = 'test_example_proto_py_genproto')
	File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ad505fa787dc3fe473b54762d1a7f9ae/external/protobuf_archive/protobuf.bzl", line 137, in _proto_gen_impl
		ctx.actions.run(inputs = inputs, outputs = outs, arg...]), <3 more arguments>)
Found tool(s) 'bazel-out/host/bin/external/grpc/grpc_python_plugin' in inputs. A tool is an input with executable=True set. All tools should be passed using the 'tools' argument instead of 'inputs' in order to make their runfiles available to the action. This safety check will not be performed once the action is modified to take a 'tools' argument. To temporarily disable this check, set --incompatible_no_support_tools_in_action_inputs=false.
```

irengrig added a commit to irengrig/bazel that referenced this issue Jun 18, 2019

Flip --incompatible_no_support_tools_in_action_inputs
Fixes bazelbuild#5826

RELNOTES: Flip --incompatible_no_support_tools_in_action_inputs
PiperOrigin-RevId: 250930436

guibou added a commit to tweag/rules_haskell that referenced this issue Jun 25, 2019

Switch --incompatible_no_support_tools_in_action_inputs
Executables must be passed as `tools` instead of `inputs`.

See: bazelbuild/bazel#5826

guibou added a commit to tweag/rules_haskell that referenced this issue Jun 26, 2019

Switch --incompatible_no_support_tools_in_action_inputs
Executables must be passed as `tools` instead of `inputs`.

See: bazelbuild/bazel#5826

guibou added a commit to tweag/rules_haskell that referenced this issue Jun 26, 2019

Switch --incompatible_no_support_tools_in_action_inputs
Executables must be passed as `tools` instead of `inputs`.

See: bazelbuild/bazel#5826

guibou added a commit to tweag/rules_haskell that referenced this issue Jun 26, 2019

Switch --incompatible_no_support_tools_in_action_inputs
Executables must be passed as `tools` instead of `inputs`.

See: bazelbuild/bazel#5826

guibou added a commit to tweag/rules_haskell that referenced this issue Jun 26, 2019

Switch --incompatible_no_support_tools_in_action_inputs
Executables must be passed as `tools` instead of `inputs`.

See: bazelbuild/bazel#5826

guibou added a commit to tweag/rules_haskell that referenced this issue Jun 26, 2019

Switch --incompatible_no_support_tools_in_action_inputs
Executables must be passed as `tools` instead of `inputs`.

See: bazelbuild/bazel#5826

guibou added a commit to tweag/rules_haskell that referenced this issue Jun 26, 2019

Switch --incompatible_no_support_tools_in_action_inputs
Executables must be passed as `tools` instead of `inputs`.

See: bazelbuild/bazel#5826

guibou added a commit to tweag/rules_haskell that referenced this issue Jun 27, 2019

Switch --incompatible_no_support_tools_in_action_inputs
Executables must be passed as `tools` instead of `inputs`.

See: bazelbuild/bazel#5826

irengrig added a commit to irengrig/bazel that referenced this issue Jul 15, 2019

Flip --incompatible_no_support_tools_in_action_inputs
Fixes bazelbuild#5826

RELNOTES: Flip --incompatible_no_support_tools_in_action_inputs
PiperOrigin-RevId: 250930436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.