Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable InMemory Tools Defaults Package #6385

Closed
hlopko opened this Issue Oct 15, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@hlopko
Copy link
Contributor

hlopko commented Oct 15, 2018

Incompatible change.

Flag: --incompatible_disable_tools_defaults_package

//tools/default was initially created as virtual in-memory package. It generates content dynamically based on current configuration. There is no need of having //tools/defaults any more as LateBoundAlias can do dynamic configuration-based label resolving. Also, having //tools/default makes negative impact on performance, and introduces unnecessary code complexity.

All references to //tools/defaults:* targets should be removed or replaced to corresponding target in @bazel_tools//tools/jdk: and @bazel_tools//tools/cpp: packages.

Migration docs.

@dslomov

This comment has been minimized.

Copy link
Contributor

dslomov commented Oct 31, 2018

Is there a flag?

@hlopko

This comment has been minimized.

Copy link
Contributor Author

hlopko commented Nov 19, 2018

Edited the text.

@dbabkin do you plan to flip the flag?

@dbabkin

This comment has been minimized.

Copy link
Contributor

dbabkin commented Nov 26, 2018

Not now.
Need to confirm that Bazel CI is cleaned up first.

@hlopko hlopko assigned dbabkin and unassigned hlopko Nov 27, 2018

@hlopko

This comment has been minimized.

Copy link
Contributor Author

hlopko commented Jan 25, 2019

Hi @dbabkin, did you have a chance to work on this?

@philwo

This comment has been minimized.

Copy link
Member

philwo commented Feb 6, 2019

I verified that this flag was flipped and thus will be included in the Bazel 0.23.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.