New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --genrule_strategy #6760

Open
ulfjack opened this Issue Nov 26, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@ulfjack
Copy link
Contributor

ulfjack commented Nov 26, 2018

I'm planning to deprecate and remove the --genrule_strategy flag in early 2019.

As of e6263c3, it is no longer necessary to set --genrule_strategy in addition to --spawn_strategy if both are set to the same value. If --genrule_strategy is not set, it now defaults to --spawn_strategy. This makes --genrule_strategy superfluous - it can already be replaced with --strategy=Genrule=<value>, and now the existence of the flag no longer implies a default strategy setting for genrules.

@ulfjack

This comment has been minimized.

Copy link
Contributor

ulfjack commented Nov 26, 2018

Note that the first step is to make --genrule_strategy a noop, which will land in January. This only requires action for users who set --spawn_strategy to a different value than --genrule_strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment