/bazel

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible_require_feature_configuration_for_pic: Require feature_configuration argument for `cc_toolchain_info.use_pic_for_dynamic_libraries`. #7007

Closed
hlopko opened this Issue Dec 28, 2018 · 2 comments

Comments

Assignees

@hlopko hlopko

Labels
P1 bazel 1.0 breaking-change-0.23 incompatible-change migration-0.22 team-Rules-CPP
Projects
None yet
Milestone
No milestone
3 participants
@hlopko @philwo @dslomov
@hlopko
Copy link
Contributor

hlopko commented Dec 28, 2018 •
edited

Flag: --incompatible_require_feature_configuration_for_pic
Available since: 0.22 (January 2019 release)
Will be flipped in: 0.23 (February 2019 release)
Tracking issue: #5883
Rollout doc: docs.google.com/document/d/1uv4c1zag6KvdI31qdx8C6jiTognXPQrxgsUpVefm9fM/edit#

Motivation

This is a part of larger incompatible change #6861. With removing legacy crosstool fields we need feature_configuration to correctly tell whether pic is required for dynamic libraries.

Migration

Pass feature_configuration instance as an argument to cc_toolchain_info.needs_pic_for_dynamic_libraries and use this method instead of cc_toolchain_info.use_pic_for_dynamic_libraries.

Impact

Minimal, the method is rarely used.

@hlopko hlopko added P1 team-Rules-CPP incompatible-change bazel 1.0 labels Dec 28, 2018

@hlopko hlopko self-assigned this Dec 28, 2018

@hlopko

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

hlopko commented Dec 28, 2018

CC @oquenchil

@hlopko hlopko added migration-ready migration-0.22 breaking-change-0.23 labels Jan 2, 2019

@meteorcloudy meteorcloudy changed the title --incompatible_require_feature_configuration_for_pic: Require feature_configuration argument for `cc_toolchain_info.use_pic_for_dynamic_libraries`. incompatible_require_feature_configuration_for_pic: Require feature_configuration argument for `cc_toolchain_info.use_pic_for_dynamic_libraries`. Jan 3, 2019

@bazel-io bazel-io closed this in 6c0707a Jan 16, 2019

weixiao-huang added a commit to weixiao-huang/bazel that referenced this issue Jan 31, 2019

@hlopko @weixiao-huang
Flip --incompatible_require_feature_configuration_for_pic 
Fixes bazelbuild#7007.

RELNOTES: --incompatible_require_feature_configuration_for_pic was flipped (bazelbuild#7007).
PiperOrigin-RevId: 229522013
589177d

@dslomov dslomov removed the migration-ready label Jan 31, 2019

@philwo

This comment has been minimized.

Sign in to view
Copy link
Member

philwo commented Feb 6, 2019

I verified that this flag was flipped and thus will be included in the Bazel 0.23.0 release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment