Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible_auto_configure_host_platform: Switch to new auto-configured host platforms #7081

Open
katre opened this Issue Jan 10, 2019 · 2 comments

Comments

Projects
None yet
1 participant
@katre
Copy link
Member

katre commented Jan 10, 2019

Flag: --incompatible_auto_configure_host_platform
Available since: 0.23
Will be flipped in: Unknown

See https://github.com/bazelbuild/proposals/blob/master/designs/2018-10-22-autoconfigured-host-platform.md for more context.
The default host and target platforms are defined in @bazel_tools//platforms, and there is special-purpose code in the Platform rule implementation to support this. This complicates the platform rules implementation and makes them dependent on the configuration.

Once this flag is enabled, Bazel will instead default to using a host platform generated by a repository rule, located at @local_config_platform//:host, and which will be created only once for a given build. The target platform will also default to this. Once migration is complete, the legacy targets and code can be removed.

Migration notes:
This only affects builds where the --host_platform and --platforms flags are not used. Any builds currently setting those flags will not be affected.

Any users who rely on --host_platform and --platforms being affected by the --host_cpu and --cpu flags will need to begin directly setting --host_platform and --platforms.

@katre katre self-assigned this Jan 10, 2019

bazel-io pushed a commit that referenced this issue Jan 10, 2019

Add the incompatible flag for using auto-configured host platform.
Part of the work on #6849.
Incompatible change issue: #7081
Closes #7070.

RELNOTES[INC]: The default value of --host_platform and --platforms will be
  changed to not be dependent on the configuration. This means that setting
  --cpu or --host_cpu will not affect the target or host platform.

PiperOrigin-RevId: 228745152

@hlopko hlopko changed the title incompatible_auto_configure_host_platform: Switch to new atuo-configured host platforms incompatible_auto_configure_host_platform: Switch to new auto-configured host platforms Jan 10, 2019

@katre

This comment has been minimized.

Copy link
Member Author

katre commented Jan 17, 2019

This flag is part of the work on #6849 .

@katre katre added migration-0.23 and removed migration-0.23 labels Jan 25, 2019

@katre

This comment has been minimized.

Copy link
Member Author

katre commented Jan 30, 2019

Changed the targetted flag-flip release, since this will require extensive testing and may need to wait for the projected migration plan for the cpu flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.