New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible_disable_legacy_proto_provider: Remove legacy `dep.proto.` access to the proto provider #7152

Open
lberki opened this Issue Jan 17, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@lberki
Copy link
Contributor

lberki commented Jan 17, 2019

We are migrating off of legacy providers that are addressed by name to providers addressed: https://bazel.build/designs/skylark/declared-providers.html

This bug is for migrating the provider containing information about .proto files. The following changes are required in Starlark sources:

  • Change the way the provider is accessed from ctx.attr.dep.proto. to ctx.attr.dep[ProtoInfo]
  • Change the way the presence of provider is checked from hasattr(dep, "proto") to ProtoInfo in dep
  • Change the way a rule requires a provider from providers = [["​proto"]] to providers = [[ProtoInfo]]
@philwo

This comment has been minimized.

Copy link
Member

philwo commented Feb 6, 2019

This flag was not flipped in time for the Bazel 0.23.0 release and will thus be postponed to Bazel 0.24.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment