Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible_dont_enable_host_nonhost_crosstool_features: Do not automatically enable "host" and "nonhost" crosstool features #7407

Open
hlopko opened this Issue Feb 12, 2019 · 2 comments

Comments

@hlopko
Copy link
Contributor

commented Feb 12, 2019

Flag: --incompatible_dont_enable_host_nonhost_crosstool_features
Available since: 0.24 (March 2019 release)
Will be flipped in: 0.25 (April 2019 release)
Tracking issue: #6516

Motivation

With the move of C++ rules to use platforms/toolchains (tracked in #6516), we are removing host specific logic. Platforms don't guarantee existence of separate host toolchain, in which case it's not clear which feature to enable, and it can happen that there will be multiple execution platforms, which currently don't have a way to enable a specific feature. My research shows that these Bazel features are actually mostly unused, so instead of coming up with non-trivial solution, we will remove them.

Migration

With the flag flipped, host and nonhost features will never be enabled automatically. There are no generally useful migration notes.

@hlopko

This comment has been minimized.

Copy link
Contributor Author

commented Feb 12, 2019

CC @katre

bazel-io pushed a commit that referenced this issue Feb 13, 2019

Add --incompatible_dont_enable_host_nonhost_crosstool_features
#7407

RELNOTES: None.
PiperOrigin-RevId: 233732318
@dkelmer

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

Seems like the flag wasn't flipped. Changing breaking-change label to 0.26

emusand added a commit to emusand/bazel that referenced this issue Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.