Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
incompatible_windows_style_arg_escaping: enables correct subprocess argument escaping on Windows #7454
When enabled, WindowsSubprocessFactory will use ShellUtils.windowsEscapeArg to escape command line arguments. This is correct, as verified by tests.
When disabled, WindowsSubprocessFactory will use ShellUtils.quoteCommandLine. This is buggy, as shown by #7122.
None, as of 2019-02-18.
We don't expect any breakages when this flag is enabled. However if it breaks your build, please let us know so we can help fixing it and provide a migration recipe.
This was referenced
Feb 28, 2019
referenced this issue
Mar 6, 2019
Apr 4, 2019
I re-added breaking change 26 because that will put this bug in the queue for the next release manager to check up on it. No pressure if it doesn't get flipped, the protocol is to extend the window in that case. But I think if it doesn't have a breaking change label it will fall through the cracks eventually.