Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible_disable_third_party_license_checking: Disable third_party licenses() checking #7553

Closed
gregestren opened this issue Feb 26, 2019 · 3 comments

Comments

Projects
None yet
1 participant
@gregestren
Copy link
Contributor

commented Feb 26, 2019

Flag: --incompatible_disable_third_party_license_checking:
Available since: 0.24 (March 2019 release)
Will be flipped in: 0.25 (April 2019 release)

License checking, which never had a coherent API, is being removed from Bazel in preference for an upcoming Starlark-based approach. See #7444 for overview.

This flag makes licenses() and distribs() no-ops and forces --check_licenses and --check_third_party_targets_have_licenses to false. In other words, it disables all license enforcement.

This will relieve users of having to declare licenses() in any rule under third_party and fix crashes when writing Starlark rules with attributes named licenses.

There is no specific migration policy. We don't expect Bazel users to depend on these semantics, so most projects should notice no difference. If you have problems, write here for custom support.

bazel-io pushed a commit that referenced this issue Feb 26, 2019

Add --incompatible_disable_third_party_license_checking.
This flag makes all license-related BUILD syntax no-ops.

After this flag is permanently turned on in Bazel, we can start
stripping out the syntax.

This is unfortunately complex because it has to coherently interplay
with the related flag --check_third_party_targets_have_licenses.

See #7444 and #7553.

PiperOrigin-RevId: 235779781

@gregestren gregestren self-assigned this Feb 26, 2019

@gregestren

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2019

This should be rolled out simultaneously with #6420 (--incompatible_no_attr_license). That's been delayed on a user crash. But that crash is fixed in a pending PR that'll be in 0.24.

@gregestren

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2019

PR mentioned above submitted: 82281ad

@gregestren

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

Looks okay according to our incompatible flags CI: https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/58

Screenshot from 2019-03-27 13-38-00

@bazel-io bazel-io closed this in c4333f4 Mar 28, 2019

emusand added a commit to emusand/bazel that referenced this issue Apr 16, 2019

Add --incompatible_disable_third_party_license_checking.
This flag makes all license-related BUILD syntax no-ops.

After this flag is permanently turned on in Bazel, we can start
stripping out the syntax.

This is unfortunately complex because it has to coherently interplay
with the related flag --check_third_party_targets_have_licenses.

See bazelbuild#7444 and bazelbuild#7553.

PiperOrigin-RevId: 235779781

emusand added a commit to emusand/bazel that referenced this issue Apr 16, 2019

Flip --incompatible_disable_third_party_license_checking.
Fixes bazelbuild#7553. Also see bazelbuild#7444.

RELNOTES[INC]: --incompatible_disable_third_party_license_checking` is enabled by default

PiperOrigin-RevId: 240855788

irengrig added a commit to irengrig/bazel that referenced this issue May 3, 2019

Flip --incompatible_disable_third_party_license_checking.
Fixes bazelbuild#7553. Also see bazelbuild#7444.

RELNOTES[INC]: --incompatible_disable_third_party_license_checking` is enabled by default

PiperOrigin-RevId: 240855788
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.