Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible_disable_objc_library_resources #7594

Closed
sergiocampama opened this Issue Feb 28, 2019 · 11 comments

Comments

Projects
None yet
4 participants
@sergiocampama
Copy link
Member

commented Feb 28, 2019

objc_library resource attributes are deprecated and will be removed. Refer to the Resources guide for more information on using resources for Apple platform targets.

In short, the following attributes are marked as deprecated:

  • asset_catalogs
  • bundles
  • datamodels
  • resources
  • storyboards
  • strings
  • structured_resources
  • xibs

Most of these attributes can be directly moved to the data attribute, except the structured_resources ones. Please refer to the Resources guide for more information.

Expected timeline:

  • released with Bazel 0.24 (March 2019), off by default
  • enabled by default with Bazel 0.25 (April 2019)
@dslomov

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2019

Please follow the guidance https://www.bazel.build/breaking-changes-guide.html for incompatible changes

@dslomov

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2019

cc @katre - we shouldn't miss this for 0.24 labels #6968.

@katre

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

@dslomov Updated, thanks for the notification.

@sergiocampama

This comment has been minimized.

Copy link
Member Author

commented Mar 6, 2019

I'm not following the migration-0.24 and breaking-change-0.26, what about 0.25? I would like to flip it as soon as I can, could it be done in 0.25?

@katre

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

The issue description says the flag will be flipped for 0.26, so that was what I chose. You can change it to 0.25 if you think all downstream projects will be migrated in time.

@sergiocampama

This comment has been minimized.

Copy link
Member Author

commented Mar 6, 2019

I've updated it for 0.25. I'm ok with pushing for this harder deadline for our clients, if that's ok with the Bazel policy

@katre

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

Labels updated.

@sergiocampama sergiocampama self-assigned this Mar 6, 2019

bazel-io pushed a commit that referenced this issue Apr 3, 2019

Flip --incompatible_disable_objc_library_resources to true.
RELNOTES[INC]: objc_library resource attributes are now disabled by default. Please migrate them to data instead. See #7594 for more info.

PiperOrigin-RevId: 241782281
@dkelmer

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

Can this be closed @sergiocampama ?

bazel-io pushed a commit that referenced this issue Apr 13, 2019

Googler Copybara-Service
Clean up framework support
RELNOTES: Add --incompatible_objc_framework_cleanup to control whether to enable some objc framework cleanup that changes the API.  Specifically, the cleanup changes the objc provider API pertaining to frameworks.  This change is expected to be transparent to most users unless they write their own Starlark rules to handle frameworks.  See #7594 for details.
PiperOrigin-RevId: 243373818
@sergiocampama

This comment has been minimized.

Copy link
Member Author

commented Apr 14, 2019

it's been flipped to true, but there's cleanup involved... what's the general guidance? should this be closed when the flag is removed? or when it's flipped to true?

@dkelmer

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

Most people tend to close the bug when the flag is flipped (this is the only open bug with "breaking change 0.25 label which is what lead me to ask), but I don't think we actually have guidelines about this so if you want to use the bug to track the cleanup I think that makes a lot of sense :)

emusand added a commit to emusand/bazel that referenced this issue Apr 16, 2019

Flip --incompatible_disable_objc_library_resources to true.
RELNOTES[INC]: objc_library resource attributes are now disabled by default. Please migrate them to data instead. See bazelbuild#7594 for more info.

PiperOrigin-RevId: 241782281

emusand added a commit to emusand/bazel that referenced this issue Apr 16, 2019

Clean up framework support
RELNOTES: Add --incompatible_objc_framework_cleanup to control whether to enable some objc framework cleanup that changes the API.  Specifically, the cleanup changes the objc provider API pertaining to frameworks.  This change is expected to be transparent to most users unless they write their own Starlark rules to handle frameworks.  See bazelbuild#7594 for details.
PiperOrigin-RevId: 243373818
@dslomov

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

I don't think we actually have guidelines about this so if you want to use the bug to track the cleanup I think that makes a lot of sense :)

We actually do: https://www.bazel.build/breaking-changes-guide.html#flipping-the-flag
When the flag is flipped to true, the corresponding incompatible-change issue should be closed.

@dslomov dslomov closed this Apr 16, 2019

bazel-io pushed a commit that referenced this issue Apr 17, 2019

Delete resource attributes from objc_library and objc_import.
The incompatible flag to disable these resources will be enabled by default in Bazel 0.25.

RELNOTES: objc_library does not support resource attributes any more. Please read #7594 for more info.
PiperOrigin-RevId: 244026921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.