Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible_require_java_toolchain_header_compiler_direct #7990

Closed
cushon opened this issue Apr 10, 2019 · 3 comments

Comments

@cushon
Copy link
Contributor

@cushon cushon commented Apr 10, 2019

See: 2ebb0a2. java_toolchain.header_compiler_direct should always be set when toolchain resolution is enabled.

No migration is needed for the built-in toolchains, or for custom toolchains using default_java_toolchain.

@hlopko

This comment has been minimized.

Copy link
Contributor

@hlopko hlopko commented Jun 7, 2019

Hi Liam, could you pls update this issue to follow https://bazel.build/breaking-changes-guide.html? (e.g. the title of the issue is not right, I could fix that myself but that link is quite nicely written and contains useful advice :).

@cushon

This comment has been minimized.

Copy link
Contributor Author

@cushon cushon commented Jun 7, 2019

The docs say the title should start with the name of the flag, which is incompatible_require_java_toolchain_header_compiler_direct. The example has a similar title. Did you already update the title, or am I missing something?

@hlopko

This comment has been minimized.

Copy link
Contributor

@hlopko hlopko commented Jun 18, 2019

Oh sorry for the confusion it was me who should read the docs. I thought the format has to be <flag-name>: Description (note the colon). Sorry again :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.