Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build speed by not registering ImportDepsChecker actions in aar_import when --experimental_import_deps_checker is "off" #8340

Closed
jin opened this issue May 15, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@jin
Copy link
Member

commented May 15, 2019

Since import deps checker is off by default in Bazel, don't register the action and create the jdeps output. Only register it if the levels are warning or error.

Build profiles for https://github.com/google/google-authenticator-android on a 12 core linux machine:

With importdepschecker:

ss

Without importdepschecker:

ss

The more AARs there are, the larger the impact of this change is.

@jin jin self-assigned this May 15, 2019

@jin

This comment has been minimized.

Copy link
Member Author

commented May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.