Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
java_tools' ijar and singlejar don't build on windows #8614
The ijar embedded in java_tools doesn't build from source on Windows.
Build one of the java_tools zips in the bazel repo:
The log includes:
The failing target is a
The BUILD file where the targets are defined is tools/jdk/BUILD.java_tools.
Example of log on Buildkite: https://storage.googleapis.com/bazel-untrusted-buildkite-artifacts/fdd75d7e-09da-44dc-8e2b-24c907722980/src%5Ctest%5Cshell%5Cbazel%5Cbazel_java_tools_javac10_test%5Cattempt_1.log
Because src/main/native/windows/util.cc in "lib-util" includes src/main/native/windows/file.h, but the rule doesn't depend on that file.
I merged the two rules (in their "main" location) to avoid a circular dependency: util.cc includes file.h and file.cc includes util.h
@laszlocsomor Yes. Some ijar sources are still under
All native Python rules have an implicit
Do you mean which sources overlap with ijar's sources? I don't know, but I can take a look and put together a list. From a quick glance they both depend on targets under