Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible_enable_profile_by_default: Switch to the JSON profile and enable it by default #8783

Closed
meisterT opened this issue Jul 3, 2019 · 3 comments

Comments

@meisterT
Copy link
Member

@meisterT meisterT commented Jul 3, 2019

This flags enables the JSON profile by default for every bazel invocation. The JSON profile is written to the output base (exact path is written to stderr) and you can load it via chrome://tracing. See also https://docs.bazel.build/versions/master/skylark/performance.html#json-profile.

It also sets the recommended options:

  • compression
  • slim profile
  • cpu profile
  • profile started event

There is no code change necessary.

We did a lot of Google-internal experiments and think it doesn't affect end to end build performance.

We intend to flip this with the next incompatible release, probably 1.0 in September.

@dslomov

This comment has been minimized.

Copy link
Contributor

@dslomov dslomov commented Aug 5, 2019

What is the breaking change here?

@meisterT

This comment has been minimized.

Copy link
Member Author

@meisterT meisterT commented Aug 5, 2019

We create a file by default that was previously not created. I don't expect any breakage here, but wanted to play safe.

meisterT added a commit to meisterT/bazel that referenced this issue Aug 13, 2019
meisterT added a commit to meisterT/bazel that referenced this issue Aug 13, 2019
bazel-io pushed a commit that referenced this issue Aug 14, 2019
RELNOTES: None

Closes #9157.

PiperOrigin-RevId: 263315874
@dslomov

This comment has been minimized.

Copy link
Contributor

@dslomov dslomov commented Sep 2, 2019

This is closed, I assume.

@dslomov dslomov closed this Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.