Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible_disable_partition_default_parameter #8953

Closed
vladmos opened this issue Jul 22, 2019 · 3 comments

Comments

@vladmos
Copy link
Member

@vladmos vladmos commented Jul 22, 2019

The flag disables the default value ' ' for sep parameter of String.partition and String.rpartition.

When the flag is flipped, one needs to provide an explicit value for the parameter, e.g. s.partition(" ").

Implemented with #8894

Expected timeline:

released with Bazel 0.29 (August 3), off by default
enabled by default with Bazel 1.0 (September 2019)

@dslomov

This comment has been minimized.

Copy link
Contributor

@dslomov dslomov commented Aug 5, 2019

Do we have migration support in buildifier?

@laurentlb

This comment has been minimized.

Copy link
Member

@laurentlb laurentlb commented Aug 6, 2019

No breakage found, neither on Bazel downstream projects, nor in the entire Google codebase.

Tooling is not useful (especially as it would have false negatives, due to the lack of static typing).

@dslomov

This comment has been minimized.

Copy link
Contributor

@dslomov dslomov commented Aug 6, 2019

No breakage found, neither on Bazel downstream projects, nor in the entire Google codebase.

Tooling is not useful (especially as it would have false negatives, due to the lack of static typing).

That sounds reasonable to me.

@laurentlb laurentlb self-assigned this Aug 6, 2019
@bazel-io bazel-io closed this in a650d81 Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.