Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak third_party/BUILD for OpenBSD. #10639

Conversation

@aldersondrive
Copy link
Contributor

aldersondrive commented Jan 23, 2020

This change was part of #10567, which was merged as commit d6145a0, but somehow that commit contains all of the changes in the PR except the changes to third_party/BUILD. Apparently the changes to that file were lost when the PR was imported into Google's internal code repository. Here is another PR for those changes that disappeared.

@aehlig FYI.

This change is part of the OpenBSD port in #10250.

third_party/BUILD Show resolved Hide resolved
bazel-io pushed a commit that referenced this pull request Feb 4, 2020
Searching the `PATH` is the only feasible way to find the executable on OpenBSD when `argv[0]` is not an absolute path or a relative path. This change resolves a TODO.

This change moves a preexisting `Which` function for searching the `PATH` out of `blaze_util_linux.cc` and into `blaze_util_posix.cc`, so that the Linux code and the BSD code can share this function.

In my testing on OpenBSD 6.6-current, a bootstrap build of Bazel succeeds and the resulting `bazel` binary can find itself on the `PATH`. (One caveat: For the bootstrap build to succeed, I had to manually apply the unrelated change in #10639, since it's not merged yet.)

This change is part of the OpenBSD port in #10250.

@jmmv FYI.

Closes #10691.

PiperOrigin-RevId: 293183553
@philwo
philwo approved these changes Feb 6, 2020
bazel-io pushed a commit that referenced this pull request Feb 6, 2020
Partial commit for third_party/*, see #10639.

Signed-off-by: Philipp Wollermann <philwo@google.com>
@philwo

This comment has been minimized.

Copy link
Member

philwo commented Feb 6, 2020

Merged in e274da3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.