Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak third_party/BUILD for FreeBSD. #10734

Conversation

@aldersondrive
Copy link
Contributor

aldersondrive commented Feb 8, 2020

This way there's no need for FreeBSD's bazel port to patch third_party/BUILD anymore. Also, this change moves one step closer to a bootstrap build on FreeBSD succeeding using unmodified sources.

#10639 made the equivalent change for OpenBSD. AFAICS the same kind of change would be helpful for FreeBSD also.

@googlebot googlebot added the cla: yes label Feb 8, 2020
@aldersondrive

This comment has been minimized.

Copy link
Contributor Author

aldersondrive commented Feb 8, 2020

I was going to send this to @aehlig, but he has apparently vanished from GitHub. @philwo and @jmmv, maybe one of you could review this change, since it's a follow-up to #10639?

@philwo
philwo approved these changes Feb 8, 2020
bazel-io pushed a commit that referenced this pull request Feb 10, 2020
Partial commit for third_party/*, see #10734.

Signed-off-by: Philipp Wollermann <philwo@google.com>
@philwo

This comment has been minimized.

Copy link
Member

philwo commented Feb 10, 2020

Thanks! Merged in 554e0f7.

@philwo philwo closed this Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.