Allow map_each to return None in TemplateDict#add_joined
#16924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hvadehra Could you review? I found this small feature very useful while picking up computed substitutions. |
Mimics the behavior of `Args#add_all`'s `map_each` callback and can be used to skip over values. Also improves the error message when the callback returns an unexpected type by including the value.
fmeum
force-pushed
the
1920-skip-join-none
branch
from
846ff8f
to
6abbb61
Compare
sgowroji
added
team-Core
hvadehra
approved these changes
Dec 6, 2022
hvadehra
added
awaiting-PR-merge
|
We could probably get this into 6.1.0, right? |
sgowroji
removed
the
awaiting-PR-merge
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 6.1.0 |
bazel-io
removed
the
potential release blocker
ShreeM01
added a commit
that referenced
this pull request
Jan 21, 2023
Mimics the behavior of `Args#add_all`'s `map_each` callback and can be used to skip over values. Also improves the error message when the callback returns an unexpected type by including the value. Closes #16924. PiperOrigin-RevId: 493609265 Change-Id: Ia9e42dd7edc2928a9945ce647d638fcb94037bc8 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mimics the behavior of
Args#add_all'smap_eachcallback and can be used to skip over values.Also improves the error message when the callback returns an unexpected type by including the value.