-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force the Bazel server Java runtime to use the root locale #17702
Conversation
This ensures consistent behavior of string operations even if the individual operations do not set a locale. Without this change, Bazel can't operate in e.g. a Turkish locale, where it fails with error messages such as: In rule 'test', size 'medium' is not a valid size. This is because Turkish case mapping rules make it so that a capital ASCII 'I' lowercases to a non-ASCII variant of 'i'.
Do we still want #17687 for clarity even though we now have this PR? |
My feeling is #17687 is no longer necessary unless we want to enable the error prone check (which is not available yet)? |
Yeah, I think I prefer this over #17687 . Less opportunity for things to go wrong. |
Do you think that this is cherry-pickable? I would have been more comfortable suggesting that with the previous approach, but I also don't see why it shouldn't be safe with this one. |
On balance, I think the fact that |
@bazel-io flag |
@bazel-io fork 6.2.0 |
This ensures consistent behavior of string operations even if the individual operations do not set a locale. Without this change, Bazel can't operate in e.g. a Turkish locale, where it fails with error messages such as: In rule 'test', size 'medium' is not a valid size. This is because Turkish case mapping rules make it so that a capital ASCII 'I' lowercases to a non-ASCII variant of 'i'. Fixes bazelbuild#17541 Closes bazelbuild#17702. PiperOrigin-RevId: 515339563 Change-Id: I8417d0befd76ba6d140588be5f7e50529af3f6c7
This ensures consistent behavior of string operations even if the individual operations do not set a locale. Without this change, Bazel can't operate in e.g. a Turkish locale, where it fails with error messages such as: In rule 'test', size 'medium' is not a valid size. This is because Turkish case mapping rules make it so that a capital ASCII 'I' lowercases to a non-ASCII variant of 'i'. Fixes #17541 Closes #17702. PiperOrigin-RevId: 515339563 Change-Id: I8417d0befd76ba6d140588be5f7e50529af3f6c7 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
This ensures consistent behavior of string operations even if the individual operations do not set a locale. Without this change, Bazel can't operate in e.g. a Turkish locale, where it fails with error messages such as: In rule 'test', size 'medium' is not a valid size. This is because Turkish case mapping rules make it so that a capital ASCII 'I' lowercases to a non-ASCII variant of 'i'. Fixes bazelbuild#17541 Closes bazelbuild#17702. PiperOrigin-RevId: 515339563 Change-Id: I8417d0befd76ba6d140588be5f7e50529af3f6c7
This ensures consistent behavior of string operations even if the individual operations do not set a locale.
Without this change, Bazel can't operate in e.g. a Turkish locale, where it fails with error messages such as:
In rule 'test', size 'medium' is not a valid size.
This is because Turkish case mapping rules make it so that a capital ASCII 'I' lowercases to a non-ASCII variant of 'i'.
Fixes #17541