[6.3.2] Ensure that extension unique names followed by ~ are prefix-free
#19167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes errors such as the following when a module provides two extensions that share a name: ``` ERROR: /my/workspace/library_path/BUILD:4:13: no such package '@_main~my_ext~2~xyz//': The repository '@_main~my_ext~2~xyz' could not be resolved: Repository '@_main~my_ext~2~xyz' is not defined and referenced by '//library_path:library_name' ERROR: Analysis of target '//my_path:my_target' failed; build aborted: ``` This was a consequence of the extension unique names followed by `~` being ``` _main~my_ext~2~ _main~my_ext~ ``` since 19a9710. Before, they were of the following form, which was prefix-free: ``` _main~my_ext2~ _main~my_ext~ ``` Fixes bazelbuild#19155 Closes bazelbuild#19156. PiperOrigin-RevId: 553567725 Change-Id: I98650663fea3bfee77752a06a99132e507d91aef
bazel-io
added
team-ExternalDeps
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Wyverald
approved these changes
Aug 3, 2023
iancha1992
removed
the
awaiting-review
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
Baseline: 283ed36 Release Notes: + Ensure that extension unique names followed by `~` are prefix-free (#19167) + Lockfile updates & fixes (#19153) (#19175) + Empty commit to try to fix CI issue (#19177) Acknowledgements: This release contains contributions from many people at Google, as well as bazel.build machine account, Fabian Meumertzheim.
chiragramani
pushed a commit
to uber-common/bazel
that referenced
this pull request
Aug 11, 2023
Baseline: 283ed36 Release Notes: + Ensure that extension unique names followed by `~` are prefix-free (bazelbuild#19167) + Lockfile updates & fixes (bazelbuild#19153) (bazelbuild#19175) + Empty commit to try to fix CI issue (bazelbuild#19177) Acknowledgements: This release contains contributions from many people at Google, as well as bazel.build machine account, Fabian Meumertzheim.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes errors such as the following when a module provides two extensions that share a name:
This was a consequence of the extension unique names followed by
~beingsince 19a9710. Before, they were of the following form, which was prefix-free:
Fixes #19155
Closes #19156.
Commit 896b358
PiperOrigin-RevId: 553567725
Change-Id: I98650663fea3bfee77752a06a99132e507d91aef