Switch macOS minimum version flag to gcc compatible version #20798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bazelbuild#20698 I'm not sure how that user got into that state yet, but it doesn't hurt for this to be gcc compatible just in case the user is intentionally using gcc on macOS
github-actions
bot
added
team-Rules-CPP
brentleyjones
approved these changes
Jan 8, 2024
|
@comius can you review? |
1 similar comment
|
@comius can you review? |
comius
approved these changes
Feb 5, 2024
comius
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 7.1.0 |
bazel-io
removed
the
potential release blocker
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Feb 6, 2024
Fixes bazelbuild#20698 I'm not sure how that user got into that state yet, but it doesn't hurt for this to be gcc compatible just in case the user is intentionally using gcc on macOS Closes bazelbuild#20798. PiperOrigin-RevId: 604515755 Change-Id: Ib9087fe6afbbb3514513a7d5d120fcf448e54f65
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
…21219) Fixes #20698 I'm not sure how that user got into that state yet, but it doesn't hurt for this to be gcc compatible just in case the user is intentionally using gcc on macOS Closes #20798. Commit 05b1f06 PiperOrigin-RevId: 604515755 Change-Id: Ib9087fe6afbbb3514513a7d5d120fcf448e54f65 Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20698
I'm not sure how that user got into that state yet, but it doesn't hurt for this to be gcc compatible just in case the user is intentionally using gcc on macOS