New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename LcovMerger to CoverageOutputGenerator. #6137

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@iirina
Contributor

iirina commented Sep 12, 2018

This renaming is essential because LcovMerger does so much more than merging lcov files (e.g.parses gcov files, filters source files, etc) and soon it will do some more (e.g. filter out sources based on the source file manifest). Keeping this name only introduces confusion when someone unfamiliar with the code tries to understand it.

RELNOTES: LcovMerger was renamed to CoverageOutputGenerator.

Please use

--coverage_report_generator=@bazel_tools//tools/test/CoverageOutputGenerator/java/com/google/devtools/coverageoutputgenerator:Main

instead of the previous

--coverage_report_generator=@bazel_tools//tools/test/LcovMerger/java/com/google/devtools/lcovmerger:Main

@googlebot googlebot added the cla: yes label Sep 12, 2018

@iirina iirina requested review from lfpino and lberki Sep 12, 2018

@lberki

lberki approved these changes Sep 12, 2018

@bazel-io bazel-io closed this in 8f4786b Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment