Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect origin NO_PROXY while preparing env for jvm #6399

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@weixiao-huang
Copy link

weixiao-huang commented Oct 16, 2018

No description provided.

@googlebot

This comment has been minimized.

Copy link

googlebot commented Oct 16, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no label Oct 16, 2018

@weixiao-huang

This comment has been minimized.

Copy link
Author

weixiao-huang commented Oct 16, 2018

I signed it!

@googlebot

This comment has been minimized.

Copy link

googlebot commented Oct 16, 2018

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@weixiao-huang weixiao-huang force-pushed the weixiao-huang:respect-no-proxy branch from 2269036 to 859c267 Oct 16, 2018

@googlebot

This comment has been minimized.

Copy link

googlebot commented Oct 16, 2018

CLAs look good, thanks!

Show resolved Hide resolved src/main/cpp/blaze.cc Outdated
Show resolved Hide resolved src/main/cpp/blaze.cc Outdated
Show resolved Hide resolved src/main/cpp/blaze.cc

@weixiao-huang weixiao-huang force-pushed the weixiao-huang:respect-no-proxy branch from 859c267 to 916f5ea Dec 26, 2018

@aiuto
Copy link
Contributor

aiuto left a comment

Just logging nits, otherwise looks good.

Show resolved Hide resolved src/main/cpp/blaze.cc Outdated

@weixiao-huang weixiao-huang force-pushed the weixiao-huang:respect-no-proxy branch from 916f5ea to cdcc8ca Jan 5, 2019

Show resolved Hide resolved src/main/cpp/blaze.cc Outdated

@weixiao-huang weixiao-huang force-pushed the weixiao-huang:respect-no-proxy branch 3 times, most recently from 88c1e02 to 84d84bc Jan 9, 2019

@weixiao-huang

This comment has been minimized.

Copy link
Author

weixiao-huang commented Jan 9, 2019

I'm confused that if I use BAZEL_LOG(INFO), I cannot see any INFO about Setting NO_PROXY to ... in the shell as shown below:
image

However, if I use BAZEL_LOG(WARNING), I can see the WARNING:
image

@aiuto

This comment has been minimized.

Copy link
Contributor

aiuto commented Jan 10, 2019

This should probably be a warning, since it is generally important to know this, as it impacts the provenance of what went into your builds.

This is breaking some of our macos integeration tests. I am investigating.

@weixiao-huang weixiao-huang force-pushed the weixiao-huang:respect-no-proxy branch from 84d84bc to 10bf28d Jan 11, 2019

@weixiao-huang

This comment has been minimized.

Copy link
Author

weixiao-huang commented Jan 11, 2019

Ok, now I use WARNING instead of INFO and push it.

@aiuto

This comment has been minimized.

Copy link
Contributor

aiuto commented Jan 11, 2019

Thanks. It looks like the last round cleared up our macos tests. I should be able to merge soon

@rupertks rupertks self-assigned this Jan 14, 2019

Show resolved Hide resolved src/main/cpp/blaze.cc Outdated
Show resolved Hide resolved src/main/cpp/blaze.cc Outdated

@weixiao-huang weixiao-huang force-pushed the weixiao-huang:respect-no-proxy branch from 10bf28d to 24a5e7a Jan 31, 2019

@googlebot

This comment has been minimized.

Copy link

googlebot commented Jan 31, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added cla: no and removed cla: yes labels Jan 31, 2019

@googlebot

This comment has been minimized.

Copy link

googlebot commented Jan 31, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added cla: no and removed cla: yes labels Jan 31, 2019

@weixiao-huang weixiao-huang force-pushed the weixiao-huang:respect-no-proxy branch from c96cbf9 to 5ae8b2b Jan 31, 2019

@googlebot

This comment has been minimized.

Copy link

googlebot commented Jan 31, 2019

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jan 31, 2019

@jin jin requested review from aiuto and removed request for bazelbuild/java-team , vladmos , jin , laurentlb , philwo , hlopko , brandjon , buchgr , lberki , dslomov , dkelmer , ahumesky , scentini , c-parsons , kevin1e100 , oquenchil , ola-rozenfeld and spomorski Jan 31, 2019

@tetromino

This comment has been minimized.

Copy link
Contributor

tetromino commented Feb 1, 2019

The real way to fix this is to tell gRPC to ignore the *_proxy env variables when setting up a channel; the API to do this was added in gRPC 1.14. I have a commit internally which does so, but it requires first updating the version of gRPC bundled with Bazel. Sorry for the wait, we hope to resolve this soon!

@tetromino

This comment has been minimized.

Copy link
Contributor

tetromino commented Feb 8, 2019

Issue #6400 was resolved by 5a02ad3.

We appreciate your contribution in this PR even though we ended up solving the issue in a somewhat different way.

@tetromino tetromino closed this Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.