Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote: implement --experimental_remote_download_outputs=toplevel #7984

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@buchgr
Copy link
Contributor

commented Apr 9, 2019

This implements the second milestone of "Remote builds without the
Bytes" and introduces the "toplevel" option for the
--experimental_remote_download_outputs flag. This mode will only
download outputs of top level targets but not outputs of intermediate
actions.

On a build of Bazel against RBE I am still seeing a 50% speed up
compared to the "all" mode.

Progress towards #6862.

@buchgr buchgr requested review from ishikhman and ola-rozenfeld as code owners Apr 9, 2019

@googlebot googlebot added the cla: yes label Apr 9, 2019

@buchgr buchgr force-pushed the buchgr:download_outputs_toplevel branch from d0b103e to 19e9570 Apr 10, 2019

@buchgr

This comment has been minimized.

Copy link
Contributor Author

commented Apr 10, 2019

@ishikhman sorry about this. this PR isn't ready for review yet. Trying to figure out test failures.

@buchgr buchgr closed this Apr 10, 2019

@ishikhman

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

@ishikhman sorry about this. this PR isn't ready for review yet. Trying to figure out test failures.

no worries :) you can address the comments anyways ;)

@buchgr buchgr reopened this Apr 10, 2019

@buchgr buchgr force-pushed the buchgr:download_outputs_toplevel branch from 19e9570 to 3e46cdd Apr 10, 2019

@ishikhman
Copy link
Contributor

left a comment

LGTM

@buchgr buchgr force-pushed the buchgr:download_outputs_toplevel branch from 3e46cdd to 3c9c787 Apr 10, 2019

remote: implement --experimental_remote_download_outputs=toplevel
This implements the second milestone of "Remote builds without the
Bytes" and introduces the "toplevel" option for the
--experimental_remote_download_outputs flag. This mode will only
download outputs of top level targets but not outputs of intermediate
actions.

On a build of Bazel against RBE I am still seeing a 50% speed up
compared to the "all" mode.

Progress towards #6862.

@buchgr buchgr force-pushed the buchgr:download_outputs_toplevel branch from 3c9c787 to 1ce5cc1 Apr 10, 2019

@bazel-io bazel-io closed this in 50c1004 Apr 11, 2019

aherrmann-da pushed a commit to digital-asset/daml that referenced this pull request Apr 12, 2019

Don't download intermediate results from cache
Using the corresponding "builds without the bytes feature".
bazelbuild/bazel#7984

aherrmann-da pushed a commit to digital-asset/daml that referenced this pull request Apr 15, 2019

Don't download intermediate results from cache
Using the corresponding "builds without the bytes feature".
bazelbuild/bazel#7984

emusand added a commit to emusand/bazel that referenced this pull request Apr 16, 2019

remote: implement --experimental_remote_download_outputs=toplevel
This implements the second milestone of "Remote builds without the
Bytes" and introduces the "toplevel" option for the
--experimental_remote_download_outputs flag. This mode will only
download outputs of top level targets but not outputs of intermediate
actions.

On a build of Bazel against RBE I am still seeing a 50% speed up
compared to the "all" mode.

Progress towards bazelbuild#6862.

Closes bazelbuild#7984.

PiperOrigin-RevId: 243029119
@ittaiz

This comment has been minimized.

Copy link
Member

commented May 9, 2019

What does this mode mean when running “test //...”? Does it evaluate to all leaves?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.