Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove worker log by default #9052

Closed
wants to merge 1 commit into from

Conversation

@keith
Copy link
Contributor

commented Aug 1, 2019

This hash change log doesn't seem actionable by the user, so we might as
well only enable it for the verbose mode.

Remove worker log by default
This hash change log doesn't seem actionable by the user, so we might as
well only enable it for the verbose mode.

@keith keith requested a review from philwo as a code owner Aug 1, 2019

@googlebot googlebot added the cla: yes label Aug 1, 2019

@keith

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

This test failure doesn't look related, looks like the bazel download failed

@philwo

philwo approved these changes Aug 1, 2019

Copy link
Member

left a comment

Do you see this often during a build? I agree that it's not very actionable for the end-user who only wants to build some stuff.. but if you see flapping between two worker hashes during a build, this indicates a very bad build performance issue (because workers get killed and restarted all the time).

@keith

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

I saw this for the first time today, with another build it went away so I assume it was an edge case around me switching bazel versions or doing a clean or something

@irengrig irengrig added the WIP label Aug 2, 2019

@keith

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

@philwo is this good to merge?

@jin

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

Importing for review by philwo@.

@jin jin added team-Local-Exec and removed WIP labels Aug 16, 2019

@bazel-io bazel-io closed this in d1e9ef9 Aug 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.