From 7f3cf82bad4754b0aaa8cf58a73af870128c021e Mon Sep 17 00:00:00 2001 From: Jakob Buchgraber Date: Mon, 2 Sep 2019 12:56:39 +0200 Subject: [PATCH] Disable runfile tree building when --remote_download_minimal Since we don't download any outputs there's no point in building the runfile tree. After this change there should no longer be dangling symlinks in the output base. It can also improve performance if symlink tree creation is slow. --- .../google/devtools/build/lib/remote/options/RemoteOptions.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java b/src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java index 7f3167c55e72fc..c8a75a049b165f 100644 --- a/src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java +++ b/src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java @@ -262,6 +262,7 @@ public RemoteOutputsStrategyConverter() { oldName = "experimental_remote_download_minimal", defaultValue = "null", expansion = { + "--nobuild_runfile_links", "--experimental_inmemory_jdeps_files", "--experimental_inmemory_dotd_files", "--experimental_remote_download_outputs=minimal"