Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chocolatey: Remove strict MSYS2 version requirement #9972

Closed
wants to merge 1 commit into from

Conversation

@philwo
Copy link
Member

commented Oct 8, 2019

The version given is very old and I don't see a reason why Bazel should depend on this exact version of MSYS2.

On Bazel's CI we just test against the latest MSYS2 version available from Chocolatey and it works fine, so one could argue that this old version is actually a very untested environment.

Users are also complaining about this (I guess because it prevents their MSYS2 version from being upgraded?): https://chocolatey.org/packages/bazel#comment-4643886227

The version given is very old and I don't see a reason why Bazel should depend on this exact version of MSYS2.

On Bazel's CI we just test against the latest MSYS2 version available from Chocolatey and it works fine, so one could argue that this old version is actually a very untested environment.

Users are also complaining about this (I guess because it prevents their MSYS2 version from being upgraded?): https://chocolatey.org/packages/bazel#comment-4643886227
@philwo philwo requested a review from meteorcloudy Oct 8, 2019
@philwo philwo self-assigned this Oct 8, 2019
@googlebot googlebot added the cla: yes label Oct 8, 2019
@philwo

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2019

FYI @petemounce - WDYT?

Copy link
Contributor

left a comment

LGTM. That'll open up support to any version since that one, though; might want to pegtoo a more recent one?

@philwo

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2019

@petemounce Thanks!

@meteorcloudy How do you feel about not restricting the supported version for msys2? Personally, I think it's fine - anything else than the latest version isn't tested on our CI anyway, because we always install the latest one from Choco and not the one specified as compatible in our own Choco package definition...

@meteorcloudy

This comment has been minimized.

Copy link
Member

commented Oct 9, 2019

I think the latest version of MSYS should work fine with Bazel. We can use that in our choco definition

@bazel-io bazel-io closed this in 7fdb342 Oct 9, 2019
@philwo philwo deleted the philwo-patch-2 branch Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.