Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup up for unit test for bazelisk.go #121

Closed
wants to merge 2 commits into from

Conversation

@aiuto
Copy link
Contributor

aiuto commented Feb 20, 2020

Add a unit test for the migration issue scanner.

This PR adds no new behavior. It just refactors getIncompatibleFlags
so we can add a test for new behavior to be added for #118

Add a unit test for the migration issue scanner.

This PR adds no new behavior. It just refactors getIncompatibleFlags
so we can add a test for new behavior to be added for #118
@aiuto aiuto requested review from philwo and fweikert Feb 20, 2020
@aiuto

This comment has been minimized.

Copy link
Contributor Author

aiuto commented Feb 24, 2020

friendly ping

@philwo
philwo approved these changes Mar 9, 2020
Copy link
Member

philwo left a comment

Thank you, Tony! This is great. Merging.

@philwo

This comment has been minimized.

Copy link
Member

philwo commented Mar 9, 2020

Merged in 4785093.

@philwo philwo closed this Mar 9, 2020
@aiuto aiuto deleted the aiuto:add_flag_test branch Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.