Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for installing custom Bazel version #81

Merged
merged 1 commit into from Aug 7, 2019

Conversation

@borkaehw
Copy link
Contributor

commented Jul 25, 2019

Fix: #79

@borkaehw

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2019

@philwo I believe this works better than the previous one. Please take a look when you get a chance. Thanks.

@borkaehw borkaehw force-pushed the lucidsoftware:github-fork-remote branch from 7cbcd8b to 5052889 Jul 25, 2019

@borkaehw

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

@philwo friendly pin here. Any feedback will be appreciated.

@philwo
Copy link
Member

left a comment

Thank you! This looks pretty good.

I had just one idea regarding naming and where to put the fork name (see comments) - let me know what you think would be most user-friendly here. :)

README.md Outdated
## How does Bazelisk download release from a fork?

It uses a simple algorithm:
- If the environment variable `USE_BAZEL_REMOTE` is set, it will use the fork name specified in the value.

This comment has been minimized.

Copy link
@philwo

philwo Aug 2, 2019

Member

Can we call this USE_BAZEL_FORK (and respectively below replace "remote" with "fork" in other places, too)?

While I understand where the name "remote" comes from, it's already a pretty often used term in Bazel (e.g. for "remote execution" and "remote caching"). I worry a bit that there might be confusion around this.

This comment has been minimized.

Copy link
@borkaehw

borkaehw Aug 2, 2019

Author Contributor

It's a good idea. Thanks.

README.md Outdated

It uses a simple algorithm:
- If the environment variable `USE_BAZEL_REMOTE` is set, it will use the fork name specified in the value.
- Otherwise, if a `.bazelremote` file exists in the current directory or recursively any parent directory, it will read the file and use the the fork name specified in it.

This comment has been minimized.

Copy link
@philwo

philwo Aug 2, 2019

Member

Instead of using a separate file, what do you think of adding a "fork/" prefix to the .bazelversion file (and general version label parsing) instead? So users could do this:

echo "philwo/latest" > ~/.bazelversion
or
USE_BAZEL_VERSION="philwo/0.28.1"

It would be backwards compatible, too.

This comment has been minimized.

Copy link
@borkaehw

borkaehw Aug 2, 2019

Author Contributor

This is a good idea too.

@borkaehw borkaehw force-pushed the lucidsoftware:github-fork-remote branch from e49dc8e to 3a89ff1 Aug 2, 2019

@borkaehw

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2019

@philwo I have made the changes. The new way looks cleaner. Please take another look.

@borkaehw borkaehw force-pushed the lucidsoftware:github-fork-remote branch from 3a89ff1 to e449f5d Aug 5, 2019

@philwo

philwo approved these changes Aug 7, 2019

Copy link
Member

left a comment

Thank you! This looks good to me.

I might slightly tweak the documentation of the version label behavior regarding "foobar/" and "/0.28.0" later, but the implemented behavior is nice and how a user would expect it to work :)

@philwo philwo merged commit 8d91241 into bazelbuild:master Aug 7, 2019

2 checks passed

buildkite/bazelisk Build #211 passed (2 minutes, 57 seconds)
Details
cla/google All necessary CLAs are signed

@borkaehw borkaehw deleted the lucidsoftware:github-fork-remote branch Aug 7, 2019

@borkaehw

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

Thanks for improving the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.