Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Bazel culprit finder for Bazel downstream jobs #356

Merged
merged 1 commit into from Oct 18, 2018

Conversation

Projects
None yet
3 participants
@meteorcloudy
Copy link
Member

meteorcloudy commented Oct 17, 2018

Fixes #353

@meteorcloudy meteorcloudy requested review from philwo and hlopko Oct 17, 2018

@hlopko

hlopko approved these changes Oct 18, 2018

Copy link
Collaborator

hlopko left a comment

LGTM, feel free to add docs though :)

@meteorcloudy meteorcloudy force-pushed the implement_culprit_finder branch 5 times, most recently from 888dad9 to bfa54be Oct 18, 2018

@meteorcloudy

This comment has been minimized.

Copy link
Member Author

meteorcloudy commented Oct 18, 2018

Definitely, I'm debugging this change at https://buildkite.com/bazel/culprit-finder ;)
I'll add doc once it works!

@meteorcloudy meteorcloudy force-pushed the implement_culprit_finder branch 3 times, most recently from 56f5b04 to 09a0a51 Oct 18, 2018

@meteorcloudy

This comment has been minimized.

Copy link
Member Author

meteorcloudy commented Oct 18, 2018

I added "culprit finder" section in the README.md file, please take a look

@hlopko

hlopko approved these changes Oct 18, 2018

Copy link
Collaborator

hlopko left a comment

Thanks!


### Culprit Finder

[Bazel downstream projects](https://buildkite.com/bazel/bazel-with-downstream-projects-bazel) is read? Use culprit finder to find out which bazel commit broke it!

This comment has been minimized.

Copy link
@hlopko

hlopko Oct 18, 2018

Collaborator

s/read/red :)

This comment has been minimized.

Copy link
@meteorcloudy

meteorcloudy Oct 18, 2018

Author Member

Done.

BAD_BAZEL_COMMIT=91eb3d207714af0ab1e5812252a0f10f40d6e4a8
```

Note: Bazel commit can only be set to commits after [63453bdbc6b05bd201375ee9e25b35010ae88aab](https://github.com/bazelbuild/bazel/commit/63453bdbc6b05bd201375ee9e25b35010ae88aab), Culprit Finder needs to download Bazel at specific commit, but we don't prebuilt Bazel binaries before this commit.

This comment has been minimized.

Copy link
@hlopko

hlopko Oct 18, 2018

Collaborator

s/don't/didn't/

This comment has been minimized.

Copy link
@meteorcloudy

meteorcloudy Oct 18, 2018

Author Member

Done.

@meteorcloudy

This comment has been minimized.

Copy link
Member Author

meteorcloudy commented Oct 18, 2018

Thanks for the review! I found the culprit finder couldn't select the correct platform, I'm fixing that.
https://buildkite.com/bazel/culprit-finder/builds/9#45185273-0b68-4be7-bfd0-70025dff1deb

@meteorcloudy meteorcloudy force-pushed the implement_culprit_finder branch 2 times, most recently from c17c603 to bc7ed64 Oct 18, 2018

@meteorcloudy

This comment has been minimized.

Copy link
Member Author

meteorcloudy commented Oct 18, 2018

Looks like it's working for all three platforms now. Please take another look~

@meteorcloudy

This comment has been minimized.

Copy link
Member Author

meteorcloudy commented Oct 18, 2018

@meteorcloudy meteorcloudy force-pushed the implement_culprit_finder branch 3 times, most recently from 795e24f to ef9e8e4 Oct 18, 2018

@hlopko

hlopko approved these changes Oct 18, 2018

@meteorcloudy meteorcloudy force-pushed the implement_culprit_finder branch 2 times, most recently from f066a1a to 3861dfb Oct 18, 2018

@philwo

This comment has been minimized.

Copy link
Member

philwo commented Oct 18, 2018

@meteorcloudy Feel free to merge when you're done with this :)

@@ -342,7 +342,7 @@ def bazelcipy_url():
"""
URL to the latest version of this script.
"""
return "https://raw.githubusercontent.com/bazelbuild/continuous-integration/master/buildkite/bazelci.py?{}".format(int(time.time()))
return "https://raw.githubusercontent.com/bazelbuild/continuous-integration/implement_culprit_finder/buildkite/bazelci.py?{}".format(int(time.time()))

This comment has been minimized.

Copy link
@philwo

philwo Oct 18, 2018

Member

Please remove this before merging though :D

This comment has been minimized.

Copy link
@meteorcloudy

meteorcloudy Oct 18, 2018

Author Member

Done ;)

Implement Bazel culprit finder for Bazel downstream jobs
Change-Id: Iac9a39a5cd51747ec667554aaa562167c27fc33c

@meteorcloudy meteorcloudy force-pushed the implement_culprit_finder branch from 3861dfb to 1eaf181 Oct 18, 2018

@meteorcloudy meteorcloudy merged commit 20d4560 into master Oct 18, 2018

1 check passed

cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.