New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to specify the Bazel version in the pipeline config #464

Merged
merged 5 commits into from Feb 3, 2019

Conversation

Projects
None yet
3 participants
@fweikert
Copy link
Member

fweikert commented Jan 30, 2019

The Bazel version can be specified for each platform individually, or for all platforms at once.

This commit only works once Bazelisk is the default bazel binary on all platforms.

@fweikert fweikert requested a review from philwo as a code owner Jan 30, 2019

@philwo
Copy link
Member

philwo left a comment

Nice!

Show resolved Hide resolved buildkite/README.md Outdated
Show resolved Hide resolved buildkite/bazelci.py Outdated
Show resolved Hide resolved buildkite/bazelci.py Outdated
Show resolved Hide resolved buildkite/bazelci.py
Show resolved Hide resolved buildkite/bazelci.py Outdated
Show resolved Hide resolved buildkite/bazelci.py
Show resolved Hide resolved buildkite/bazelci.py
@googlebot

This comment has been minimized.

Copy link

googlebot commented Feb 2, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@fweikert fweikert force-pushed the fweikert:version branch from 1f37e95 to 66eb98e Feb 3, 2019

@googlebot

This comment has been minimized.

Copy link

googlebot commented Feb 3, 2019

CLAs look good, thanks!

@fweikert fweikert force-pushed the fweikert:version branch from 66eb98e to 77a3114 Feb 3, 2019

@philwo

philwo approved these changes Feb 3, 2019

@philwo

This comment has been minimized.

Copy link
Member

philwo commented Feb 3, 2019

Could you rebase against master and update this to work with your other change ("Change the pipeline configuration from platforms to tasks")? It seems like some code introduced here still relies on platforms instead of tasks?

fweikert added some commits Jan 29, 2019

Allow users to specify the Bazel version in the pipeline config.
This change only works once Bazelisk is the default bazel binary on all platforms.

@fweikert fweikert force-pushed the fweikert:version branch from 77a3114 to 04782c8 Feb 3, 2019

@fweikert

This comment has been minimized.

Copy link
Member Author

fweikert commented Feb 3, 2019

PTAL - had to change the code a bit to handle the merge.

@philwo

philwo approved these changes Feb 3, 2019

@philwo philwo merged commit c8642af into bazelbuild:master Feb 3, 2019

1 check passed

cla/google All necessary CLAs are signed
@philwo

This comment has been minimized.

Copy link
Member

philwo commented Feb 3, 2019

Great work, thanks!! :) Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment