Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bazelisk's build.sh script to build release binaries. #792

Merged
merged 1 commit into from Aug 7, 2019

Conversation

@philwo
Copy link
Member

commented Aug 7, 2019

This ensures that we use the correct stamping for the embedded version number.

Use Bazelisk's build.sh script to build release binaries. This ensure…
…s that we use the correct stamping for the embedded version number.

@philwo philwo requested a review from fweikert Aug 7, 2019

@philwo philwo self-assigned this Aug 7, 2019

@fweikert

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

SGTM - let's test on Linux and then switch to MacOS if it doesn't work.

@fweikert fweikert merged commit 2093c44 into master Aug 7, 2019

2 checks passed

buildkite/continuous-integration Build #740 passed (2 minutes, 13 seconds)
Details
cla/google All necessary CLAs are signed

@fweikert fweikert deleted the bazelisk-releases branch Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.