Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read pipeline name from the environment #836

Merged
merged 2 commits into from Oct 9, 2019

Conversation

@fweikert
Copy link
Member

commented Sep 26, 2019

This commit allows us to display annotations for incompatible flags in any regular (=non-downstream) pipeline that uses bazelisk --migrate.

This feature is already being used by https://buildkite.com/bazel/bazel-federation-bazel-rc-plus-incompatible-flags

This commit allows us to display annotations for incompatible flags in any regular (=non-downstream) pipeline that uses bazelisk --migrate.
@fweikert fweikert requested a review from philwo as a code owner Sep 26, 2019
Copy link
Member

left a comment

We can remove this flag and the hardcoded flag name and instead get the correct value from os.environ["BUILDKITE_PIPELINE_SLUG"]:

Screenshot 2019-10-09 at 14 04 46

@fweikert fweikert changed the title Allow to specify pipeline name via flag Read pipeline name from the environment Oct 9, 2019
@fweikert fweikert merged commit c795038 into bazelbuild:master Oct 9, 2019
2 checks passed
2 checks passed
buildkite/continuous-integration/pr Build #934 passed (20 seconds)
Details
cla/google All necessary CLAs are signed
@fweikert fweikert deleted the fweikert:agg_pipe branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.