Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also print --migrate annotations for regular pipelines #837

Open
wants to merge 3 commits into
base: master
from

Conversation

@fweikert
Copy link
Member

commented Sep 26, 2019

If a regular (=non-downstream) pipeline is run with the USE_BAZELISK_MIGRATE env var, this commit ensures that Buildkite displays annotations for all flags that must be migrated, similar to the current behavior in a downstream pipeline.

It has been tested as part of https://buildkite.com/bazel/bazel-federation-bazel-rc-plus-incompatible-flags.

fweikert added 2 commits Sep 25, 2019
This change allows us to test all of the CI scripts more easily since they can be in arbitrary GitHub repositories and branches.
If a regular (=non-downstream) pipeline is run with the USE_BAZELISK_MIGRATE env var, this commit ensures that Buildkite displays annotations for all flags that must be migrated, similar to the current behavior in a downstream pipeline.
@fweikert fweikert requested a review from philwo as a code owner Sep 26, 2019
@fweikert

This comment has been minimized.

Copy link
Member Author

commented Sep 26, 2019

Please only review the second commit here, since the first one is part of #838

@philwo
philwo approved these changes Oct 9, 2019
Copy link
Member

left a comment

This seems like a nice feature, thanks :)

No need to set this flag since the script reads the pipeline slug from the environment variables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.