Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation about USE_BAZELISK_MIGRATE #865

Merged
merged 2 commits into from Oct 28, 2019

Conversation

@fweikert
Copy link
Member

fweikert commented Oct 28, 2019

Belongs to #859

Belongs to #859
@fweikert fweikert requested a review from philwo as a code owner Oct 28, 2019
@fweikert fweikert requested review from meteorcloudy and hlopko Oct 28, 2019
@hlopko

This comment has been minimized.

Copy link
Collaborator

hlopko commented Oct 28, 2019

@hlopko
hlopko approved these changes Oct 28, 2019
@hlopko

This comment has been minimized.

Copy link
Collaborator

hlopko commented Oct 28, 2019

Actually you could also put USE_BAZELISK_MIGRATE to presubmit.yml if you wanted to, right? Maybe we can tweak the doc a bit to explain what changing presubmit.yml does and what settings in buildkite do.

@fweikert

This comment has been minimized.

Copy link
Member Author

fweikert commented Oct 28, 2019

The first version of the documentation was actually incorrect since bazelci.yp doesn't honor top-level env vars in the pipeline configuration.

+1 to improving the documentation :)

@fweikert fweikert merged commit 0112379 into master Oct 28, 2019
2 checks passed
2 checks passed
buildkite/continuous-integration/pr Build #1003 passed (21 seconds)
Details
cla/google All necessary CLAs are signed
@fweikert fweikert deleted the fweikert-patch-2 branch Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.